public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] net/macb: add support for resetting PHY using GPIO
Date: Wed, 16 Dec 2015 20:09:39 +0100	[thread overview]
Message-ID: <878u4utdl8.fsf@free-electrons.com> (raw)
In-Reply-To: <20151216190431.GB28759@localhost.localdomain> (Richard Cochran's message of "Wed, 16 Dec 2015 20:04:31 +0100")

Hi Richard,
 
 On mer., d?c. 16 2015, Richard Cochran <richardcochran@gmail.com> wrote:

> On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote:
>> +Optional properties for PHY child node:
>> +- reset-gpios : Should specify the gpio for phy reset
>
> reset-gpios plural or reset-gpio singular?

The bindings name is plural but it handle only one gpio.

See:
https://lkml.org/lkml/2015/12/9/623

>
>> +
>>  Examples:
>>  
>>  	macb0: ethernet at fffc4000 {
>> @@ -29,4 +32,8 @@ Examples:
>>  		local-mac-address = [3a 0e 03 04 05 06];
>>  		clock-names = "pclk", "hclk", "tx_clk";
>>  		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
>> +		ethernet-phy at 1 {
>> +			reg = <0x1>;
>> +			reset-gpios = <&pioE 6 1>;
>
> Did you mean "gpioE" ?

No, I really mean pioE: it is the name used for the at91 SoCs.

Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2015-12-16 19:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 18:31 [PATCH v3] net/macb: add support for resetting PHY using GPIO Gregory CLEMENT
2015-12-16 19:04 ` Richard Cochran
2015-12-16 19:09   ` Gregory CLEMENT [this message]
2015-12-16 19:10 ` Arnd Bergmann
2015-12-17  8:39   ` Gregory CLEMENT
2015-12-17  9:51     ` [PATCH] net/macb: Update device tree binding " Gregory CLEMENT
2015-12-17 20:53       ` David Miller
2015-12-17 16:59     ` [PATCH v3] net/macb: add support " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878u4utdl8.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox