linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] arm: pxa: add device-tree irq init for pxa27x
Date: Mon, 13 Oct 2014 20:18:05 +0200	[thread overview]
Message-ID: <878ukj96le.fsf@free.fr> (raw)
In-Reply-To: <20141013103422.GF14739@leverpostej> (Mark Rutland's message of "Mon, 13 Oct 2014 11:34:22 +0100")

Mark Rutland <mark.rutland@arm.com> writes:

> On Sun, Oct 12, 2014 at 04:28:48PM +0100, Robert Jarzmik wrote:
>> Add the initializer for irqs in a device-tree machine on a pxa27x.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>>  arch/arm/mach-pxa/pxa27x.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
>> index b040d7d..8ca62e2 100644
>> --- a/arch/arm/mach-pxa/pxa27x.c
>> +++ b/arch/arm/mach-pxa/pxa27x.c
>> @@ -398,6 +398,11 @@ void __init pxa27x_init_irq(void)
>>  	pxa_init_irq(34, pxa27x_set_wake);
>>  }
>>  
>> +void __init pxa27x_dt_init_irq(void)
>> +{
>> +	pxa_dt_irq_init(pxa27x_set_wake);
>> +}
>
> Should this also add a user of this function?
Well, patches 1, 2, 3 are preparing patch 4.
And patch 4 is adding the user of this function.

I could meld this in patch 4, but it looks cleaner for me to split the function
creation, and pxa27x dt support in 2 distinct patches.

Cheers

--
Robert

  reply	other threads:[~2014-10-13 18:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 15:28 [PATCH v2 0/4] Add support for pxa27x device-tree machine Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 1/4] arm: pxa: add device-tree irq init for pxa27x Robert Jarzmik
2014-10-13 10:34   ` Mark Rutland
2014-10-13 18:18     ` Robert Jarzmik [this message]
2014-10-12 15:28 ` [PATCH v2 2/4] arm: pxa: move init functions into generic.h Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 3/4] arm: pxa: remove unecessary includes from pxa-dt Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 4/4] arm: pxa: add pxa27x device-tree support Robert Jarzmik
2014-10-30  6:55 ` [PATCH v2 0/4] Add support for pxa27x device-tree machine Robert Jarzmik
2014-10-30  7:07   ` Arnd Bergmann
2014-11-03  7:32     ` Robert Jarzmik
2014-11-03 10:11       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ukj96le.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).