From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 27 Jul 2012 12:36:33 -0700 Subject: [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting In-Reply-To: <1342189185-5306-5-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 13 Jul 2012 17:19:41 +0300") References: <1342189185-5306-1-git-send-email-t-kristo@ti.com> <1342189185-5306-5-git-send-email-t-kristo@ti.com> Message-ID: <878ve5j8se.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tero Kristo writes: > mpu / core powerdomain usecounts are now statically increased > by 1 during MPU activity. This allows the domains to reflect > actual usage, and will allow the usecount to reach 0 just before > all CPUs are ready to idle. Proper powerdomain usecounts are > propageted to voltagedomain level also, and will allow vc > callbacks to be triggered at right point of time. > > Signed-off-by: Tero Kristo > Cc: Paul Walmsley > Cc: Kevin Hilman IMO, the idea is fine, but I'm not crazy about the implementation in powerdomain.c, which is meant for pwrdm generic code. In particular, I'm not crazy about the pwrdm lookups in powerdomain.c. Since pm.c already has references to mpu_pwrdm and core_pwrdm, why not just add the pwrdm_clkdm_enable/disable calls directly in pm.c Also, the changelog should be a bit more specific about why CORE powerdomain is also handled here when most of the code only talks about the CPU. Kevin