[PATCHv2] omap2/3: dmtimer: Enable autoidle

[PATCHv2] omap2/3: dmtimer: Enable autoidle

[Santosh Shilimkar]

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Tero Kristo
> Sent: Tuesday, February 15, 2011 10:00 PM
> To: linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle
>
> This saves some power. OMAP4 version should check for GPT module ID,
> as
> autoidle is only supported on a subset of these.
>
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> ---
>  arch/arm/plat-omap/dmtimer.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> omap/dmtimer.c
> index 1d706cf..ee9f6eb 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
> omap_dm_timer *timer)
>  	l |= 0x02 << 3;  /* Set to smart-idle mode */
>  	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on
> idle */
>
> +	/* Enable autoidle on OMAP2 / OMAP3 */
> +	if (cpu_is_omap24xx() || cpu_is_omap34xx())
> +		l |= 0x1 << 0;
> +
We should get rid of this CPU checks. How about adding a flag
and populating it on init for the architectures it supports.


>  	/*
>  	 * Enable wake-up on OMAP2 CPUs.
>  	 */
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv2] omap2/3: dmtimer: Enable autoidle

[Kevin Hilman]

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

>> -----Original Message-----
>> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
>> owner at vger.kernel.org] On Behalf Of Tero Kristo
>> Sent: Tuesday, February 15, 2011 10:00 PM
>> To: linux-omap at vger.kernel.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle
>>
>> This saves some power. OMAP4 version should check for GPT module ID,
>> as
>> autoidle is only supported on a subset of these.
>>
>> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
>> ---
>>  arch/arm/plat-omap/dmtimer.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
>> omap/dmtimer.c
>> index 1d706cf..ee9f6eb 100644
>> --- a/arch/arm/plat-omap/dmtimer.c
>> +++ b/arch/arm/plat-omap/dmtimer.c
>> @@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
>> omap_dm_timer *timer)
>>  	l |= 0x02 << 3;  /* Set to smart-idle mode */
>>  	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on
>> idle */
>>
>> +	/* Enable autoidle on OMAP2 / OMAP3 */
>> +	if (cpu_is_omap24xx() || cpu_is_omap34xx())
>> +		l |= 0x1 << 0;
>> +
> We should get rid of this CPU checks. How about adding a flag
> and populating it on init for the architectures it supports.
>

Instead, this should be implemented on top of Tarun's hwmod conversion
which knows that different timers have different capabilities (e.g. 1ms)
and autoidle can be set based on capabilities.

Kevin

[PATCHv2] omap2/3: dmtimer: Enable autoidle

[Santosh Shilimkar]

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman at ti.com]
> Sent: Tuesday, February 15, 2011 9:50 PM
> To: Santosh Shilimkar
> Cc: Tero Kristo; linux-omap at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCHv2] omap2/3: dmtimer: Enable autoidle
>
> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>
> >> -----Original Message-----
> >> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> >> owner at vger.kernel.org] On Behalf Of Tero Kristo
> >> Sent: Tuesday, February 15, 2011 10:00 PM
> >> To: linux-omap at vger.kernel.org
> >> Cc: linux-arm-kernel at lists.infradead.org
> >> Subject: [PATCHv2] omap2/3: dmtimer: Enable autoidle
> >>
> >> This saves some power. OMAP4 version should check for GPT module
> ID,
> >> as
> >> autoidle is only supported on a subset of these.
> >>
> >> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> >> ---
> >>  arch/arm/plat-omap/dmtimer.c |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> >> omap/dmtimer.c
> >> index 1d706cf..ee9f6eb 100644
> >> --- a/arch/arm/plat-omap/dmtimer.c
> >> +++ b/arch/arm/plat-omap/dmtimer.c
> >> @@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct
> >> omap_dm_timer *timer)
> >>  	l |= 0x02 << 3;  /* Set to smart-idle mode */
> >>  	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on
> >> idle */
> >>
> >> +	/* Enable autoidle on OMAP2 / OMAP3 */
> >> +	if (cpu_is_omap24xx() || cpu_is_omap34xx())
> >> +		l |= 0x1 << 0;
> >> +
> > We should get rid of this CPU checks. How about adding a flag
> > and populating it on init for the architectures it supports.
> >
>
> Instead, this should be implemented on top of Tarun's hwmod
> conversion
> which knows that different timers have different capabilities (e.g.
> 1ms)
> and autoidle can be set based on capabilities.
>
You are right. Looking at patches it's seems to be already
implemented.

So this patch isn't needed really.

Regards,
Santosh

[PATCHv2] omap2/3: dmtimer: Enable autoidle

[Tero Kristo]

This saves some power. OMAP4 version should check for GPT module ID, as
autoidle is only supported on a subset of these.

Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
---
 arch/arm/plat-omap/dmtimer.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 1d706cf..ee9f6eb 100644
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -342,6 +342,10 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer)
 	l |= 0x02 << 3;  /* Set to smart-idle mode */
 	l |= 0x2 << 8;   /* Set clock activity to perserve f-clock on idle */
 
+	/* Enable autoidle on OMAP2 / OMAP3 */
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+		l |= 0x1 << 0;
+
 	/*
 	 * Enable wake-up on OMAP2 CPUs.
 	 */
-- 
1.7.1

[PATCHv2] omap2/3: dmtimer: Enable autoidle

[Paul Walmsley]

On Tue, 15 Feb 2011, Tero Kristo wrote:

> This saves some power. OMAP4 version should check for GPT module ID, as
> autoidle is only supported on a subset of these.
> 
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>

Thanks, queued for 2.6.39 since it looks like these won't be converted to 
hwmod in time for 2.6.39.


- Paul