From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01370C3600B for ; Tue, 25 Mar 2025 16:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d4VnD3UUE4VcZVkz6IwiboRLnwKwbUMr0aWfWBRVcNw=; b=Wa6J1E9CoWkRd7GkICAamhxK1m 8KXDkmqV9h6h1DjC1oGI7ErYCEVI4E+Ue6+sWa2MT7xnlAiSrws2R8/U0Xmo1itwocMqOyZiVTm2v ul85dUcepTL5mRiO/wSmsdbGRSZncThqdzv2v6/vgj22lxR/34gDKpMnhUOvq+zgUsSUz5m65whLL F9C8r60WSUaPGmpBDD8sjVVRFl7E2CMtgUE/Wyty4Yd3A1UJMagFvqXm4qQVPV5HOStoP08VzR/Gj 67zfP8mv5lE2BNY101zu0gk250ho/T10LEO1hpsonJthPiWA7czDVozA0y3gA3uArnXtHPuv/KCrv RqnoILyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tx7UH-00000006XNo-3xGo; Tue, 25 Mar 2025 16:50:49 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tx7SY-00000006X6L-2Jbf for linux-arm-kernel@lists.infradead.org; Tue, 25 Mar 2025 16:49:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C441743DA2; Tue, 25 Mar 2025 16:49:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3B7CC4CEE4; Tue, 25 Mar 2025 16:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742921342; bh=avp/c6N3lRSJ103iDEDRC4JwYP0yydF8DWmS20ImOPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KUks1kwH7x+Q14S4ujHF1c73NCLQjw3NeZQ/ngWizjFUbNu9nfKtQkTau8pmgUky3 DUC+fcV0cMw4cKVOFQZ4mtSRJLaBBIplIoLSbwgwEEdyTIywjydZEL6yDq8i5rn3Ow il+ixE64HXNAXRJIqPiEbQXzGGqDVqwQaEdm4o5CjXmEXrQzTP+An4dfz1OUN5AS2O NWMVAfJ0ViFxKzxXMCmrwYT1WOwEM9W3esYmTo2IApJAL0TNyxqvYevuU1kU9OoX1Z FfzpeQe2+tXedbaPg8Cla5zztvod2Twt5hRREim5sK7Iyh2FqH1ehWgdWwfzovp8qk Zehst1E9utW/g== Received: from 82-132-218-87.dab.02.net ([82.132.218.87] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tx7SU-00H1BS-Un; Tue, 25 Mar 2025 16:48:59 +0000 Date: Tue, 25 Mar 2025 16:48:53 +0000 Message-ID: <87a599qcne.wl-maz@kernel.org> From: Marc Zyngier To: Mark Kettenis Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, alyssa@rosenzweig.io, j@jannau.net, marcan@marcan.st, sven@svenpeter.dev, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org Subject: Re: [PATCH v2 01/13] dt-bindings: pci: apple,pcie: Add t6020 compatible string In-Reply-To: <87ecyl6rtw.fsf@bloch.sibelius.xs4all.nl> References: <20250325102610.2073863-1-maz@kernel.org> <20250325102610.2073863-2-maz@kernel.org> <87iknx75at.fsf@bloch.sibelius.xs4all.nl> <864izhmkzd.wl-maz@kernel.org> <87ecyl6rtw.fsf@bloch.sibelius.xs4all.nl> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 82.132.218.87 X-SA-Exim-Rcpt-To: mark.kettenis@xs4all.nl, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, alyssa@rosenzweig.io, j@jannau.net, marcan@marcan.st, sven@svenpeter.dev, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250325_094902_631256_CB13F892 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 Mar 2025 15:41:15 +0000, Mark Kettenis wrote: > > > Date: Tue, 25 Mar 2025 11:02:30 +0000 > > From: Marc Zyngier > > Hi Marc, > > > Hi Mark, > > > > On Tue, 25 Mar 2025 10:50:18 +0000, > > Mark Kettenis wrote: > > > > > > > From: Marc Zyngier > > > > Date: Tue, 25 Mar 2025 10:25:58 +0000 > > > > > > > @@ -50,6 +55,10 @@ properties: > > > > - const: port1 > > > > - const: port2 > > > > - const: port3 > > > > + - const: phy0 > > > > + - const: phy1 > > > > + - const: phy2 > > > > + - const: phy3 > > > > Do we need to make this t6020 specific? > > > > Obviously, separate PHY registers do not make much sense before t6020, > > but I couldn't find a way to describe that. I don't even know if > > that's a desirable outcome. > > I don't think there is a way to do that other than creating a separate > binding for t6020. But I'm far from a dt-schema expert. Maybe robh > has some advice here. Huh, I'd rather not create another binding. The only thing this would buy us is a stricter checking of the register ranges. But it isn't like this block is going to find its way in random HW, and this is only described in a handful of core dtsi files anyway. Unless someone screams (and provides a reasonable alternative), I will leave it as is. Thanks, M. -- Without deviation from the norm, progress is not possible.