From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 023C1C48BF8 for ; Mon, 19 Feb 2024 14:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1TdULYr9lQGKldlBHlR5rxK+d9VjTdWeOiLfBWpxepw=; b=cDMDdmp3VLR3P1 EkN/BU/4NTGYPjMg53XUC3bh48lXTgS7OETLCJULBP4C1xmpIcGBPnKVfru+eBOhiBNBiPMXLrJu1 8iDw/yK8hPhrKo26hibYvNmqqWbGVqctlOxPVFRmKvYyRa38EKCl0D1Hvoj3/Dyfzuu9X46xvPo5a igEZCBhKW0QpQ4U9JnAi6Njm4lHglYwJewBi//0yqiYO/Y5lwG6XALDSvZs6uaQ8fRoQdGiQhXT9a gi1vryrUGfnLfpRYRVVlnDQ4Qj+z+XzniHCGXbllHbWgLPRntXpGs+GyUbhACS8basfpAIOAsBwBr //Gwmwg7aciuUTKeSY0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4XZ-0000000AouV-1xOG; Mon, 19 Feb 2024 14:22:41 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4XU-0000000AotO-153W for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 14:22:38 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708352554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8iEgdflkmZKXImf680lz4hgFumtn+q/R0YDjSc4t/Vc=; b=4upGx7kJ727A884ML4hUkx8C8e9g9smfQg662DB+Eql0qhnTPCpSxSOyFEBVeuIEZl3D2x lifGEA6YdZDxZ3NATNyidGIV9C47gWKE1F+bi+RMUbfG6GS5JyQqSU1eF7ydP141pP96cO Ejs2/ZFtgYFx6xD+cXA+D6dF14bXZ1Bzog1pajHS8HEuh3FLJOXqNLOya45j2829Og2LQV KSVySQTHgr2Cwbsv/m17DEgTr0sZup4bsdHay2QH+ElPRfgphVBLWy8FzODQOHxWfmARqj +TEWoE/Dyg9x3UBjG4oHCdTBdpxv3lEZlgWMKlBfaLh5q6Id5RObd4Dpti1oRQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708352554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8iEgdflkmZKXImf680lz4hgFumtn+q/R0YDjSc4t/Vc=; b=4+9ecyFEBiX9R65rg3DVI+yqWFudZBvINi2tHB1FDWo7lijLMJysfGElaqbRllJylJYfxs KB6fhvkKSS/LqXBg== To: Antonio Borneo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Catalin Marinas , Will Deacon Cc: Antonio Borneo , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 03/12] irqchip/stm32-exti: Map interrupts through interrupt nexus node In-Reply-To: <20240216094758.916722-4-antonio.borneo@foss.st.com> References: <20240216094758.916722-1-antonio.borneo@foss.st.com> <20240216094758.916722-4-antonio.borneo@foss.st.com> Date: Mon, 19 Feb 2024 15:22:34 +0100 Message-ID: <87a5nwa5zp.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_062236_456881_794A4D97 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 16 2024 at 10:47, Antonio Borneo wrote: > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c > index 69982f21126a..95bb3dd10b2c 100644 > --- a/drivers/irqchip/irq-stm32-exti.c > +++ b/drivers/irqchip/irq-stm32-exti.c > @@ -61,6 +61,7 @@ struct stm32_exti_host_data { > struct stm32_exti_chip_data *chips_data; > const struct stm32_exti_drv_data *drv_data; > struct hwspinlock *hwlock; > + struct device_node *irq_map_node; Please keep variable declarations ordered in reverse fir tree layout: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations > }; > > static struct stm32_exti_host_data *stm32_host_data; > @@ -713,8 +714,9 @@ static int stm32_exti_h_domain_alloc(struct irq_domain *dm, > u8 desc_irq; > struct irq_fwspec *fwspec = data; > struct irq_fwspec p_fwspec; > + struct of_phandle_args out_irq; Please move this into the condition path where it is actually used. > irq_hw_number_t hwirq; > - int bank; > + int bank, ret; > u32 event_trg; > struct irq_chip *chip; > > @@ -731,6 +733,25 @@ static int stm32_exti_h_domain_alloc(struct irq_domain *dm, > > irq_domain_set_hwirq_and_chip(dm, virq, hwirq, chip, chip_data); > > + if (host_data->irq_map_node) { > + out_irq.np = host_data->irq_map_node; Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel