From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4851CC77B7E for ; Thu, 1 Jun 2023 12:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7BWhGgyUjdhywGvks6w7Tr+TO8NpnI78lQSDRCWXXik=; b=ZobyA394iVHhdb 57aKD1OdOiuFnrNWn0H2nAWmmtEd8qS8P5m1rtNfpdLrGrQunonH6KYcIeTBiAsxa7FJZ20Xw5LtH NXGVQTg1Jq5nl3VQBQFZRUN8pbUgL839HHiD881PwR/7uz5x/u8ABlvywrW43UZRviyp4Pz+PCowC dLGxrnDOWK9qZyQmZAuGWb8xFD1AubvR6ucNJ1nrzxpIPBqstetyQnM5P04KBXmidq/AfHGdfuYtj B/olrUOJWpeeJHEtF+A2tRoptcJg1fThMwPUTNCAWoPgusPoCJwSOavDghihpQP8fjcwXAILOKZnR xDQxhvCMVOH+v2i8I+fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4hoe-003bch-27; Thu, 01 Jun 2023 12:54:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4hob-003bbm-1B for linux-arm-kernel@lists.infradead.org; Thu, 01 Jun 2023 12:54:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB27E60C86; Thu, 1 Jun 2023 12:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 230FFC433EF; Thu, 1 Jun 2023 12:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685624044; bh=pbesp0NO1KH5e3oQruTiP3N5y115R9AQL4odaukKjJI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ouP6d0KOA8BJT16PeyxfDIVDfmiOrwpX3wfScp4fr6IHguDkxV92wWk+GL4Hjue3b lCS93LjHqy849GuLC9eqMZ79HUbU8OPaHN6lc4EFoj9nwlBRbPz5RyEjnBAlBHMTSO s3C1A0kaymKeIEDk0TYlhq1TLMwDs3IzGMgQVux1GdEg4P0EdMoek5SJiGANnIOYcR lMtL6qShQE1baNAgSBufRAP9AoagwYeURGl8V0tJLOLELxxmOw0llHgoooa8I2g+E+ h/77UUNLJWJvmgH9EEozT+CkjgsxeisqkQMXly4MXP8/HuLtymobOeLJElHk/AM3dA mSmjJ5zOgoqEw== Received: from 90.4.23.109.rev.sfr.net ([109.23.4.90] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q4hoY-0021mW-4F; Thu, 01 Jun 2023 13:54:02 +0100 Date: Thu, 01 Jun 2023 13:54:01 +0100 Message-ID: <87a5xjpcly.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org, catalin.marinas@arm.com, suzuki.poulose@arm.com, will@kernel.org Subject: Re: [PATCH 3/4] arm64: cpufeature: use cpucap naming In-Reply-To: <20230601100812.2303944-4-mark.rutland@arm.com> References: <20230601100812.2303944-1-mark.rutland@arm.com> <20230601100812.2303944-4-mark.rutland@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 109.23.4.90 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, broonie@kernel.org, catalin.marinas@arm.com, suzuki.poulose@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_055405_487259_DC153E16 X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 01 Jun 2023 11:08:11 +0100, Mark Rutland wrote: > > To more clearly align the various users of the cpucap enumeration, this patch > changes the cpufeature code to use the term `cpucap` in favour of `cpu_hwap`. > This more clearly aligns with other users of the cpucaps, and avoids confusion > with the ELF hwcaps. > > There should be no functional change as a result of this patch; this is > purely a renaming exercise. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Marc Zyngier > Cc: Mark Brown > Cc: Suzuki Poulose > Cc: Will Deacon > --- > arch/arm64/include/asm/mmu_context.h | 2 +- > arch/arm64/kernel/cpufeature.c | 38 ++++++++++++++-------------- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/arch/arm64/include/asm/mmu_context.h b/arch/arm64/include/asm/mmu_context.h > index 56911691bef05..7f332854c961e 100644 > --- a/arch/arm64/include/asm/mmu_context.h > +++ b/arch/arm64/include/asm/mmu_context.h > @@ -164,7 +164,7 @@ static inline void cpu_replace_ttbr1(pgd_t *pgdp, pgd_t *idmap) > * up (i.e. cpufeature framework is not up yet) and > * latter only when we enable CNP via cpufeature's > * enable() callback. > - * Also we rely on the cpu_hwcap bit being set before > + * Also we rely on the system_cpucap bit being set before > * calling the enable() function. > */ > ttbr1 |= TTBR_CNP_BIT; nit: Shout this be moved to the first patch instead? It only differs by being singular instead of plural. On the other hand, I have a series that eradicates this code altogether, so I can't say I care deeply! ;-) Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel