From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C138C432BE for ; Wed, 1 Sep 2021 12:40:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A6DC6115C for ; Wed, 1 Sep 2021 12:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A6DC6115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D6pFNb4ThYNwkAOSzwn1DDPZ90n6jUVuKTuB6giJCmI=; b=aZFgmzNhBG8iob 3T9mcxh8cAbvU8XWg7+O6f4nYcA8XfitOJ9hdU7o331mj44j33Nxui5JH6ilQm4E8VESevoclXUzz PO9+67bFVq3F/GQhc+jluDHmfxPlsyCTsMMHk97tqNKe3F9WVbIPPRiybo1PuLxZBCG43vUCKG2oN 5goV6flY+HYJXLzAKMwvMjwCd7cmgXOI+ia6tc79JsP/6UKMULOLccTulEkLEU/FHe4h7203EMkYc HzVr3z9Es0/tK1hb1wyVEPqexn3LGrpU4en7UsiIkBbxQ4QiikfMBIT5S3bTUiQlYbcxi5wGTsDVL JyokOpznWw7nudirJVJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLPVT-0061MH-Hs; Wed, 01 Sep 2021 12:38:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLPUz-0061Ay-SZ for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 12:37:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED3D7611F0; Wed, 1 Sep 2021 12:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630499869; bh=Vz1TA47llC7a59hhyNGoaeEiKl47puwT1GS5TQq5ado=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=YdxJ445rGLT787Ao50jV8Np6uKoGqrJdbGH9KahNCNKH/45AAoVWJAx5KWZdNEg/7 JMEGKO849LZKAoBLVIwYNSuQEmPNjT939maSN46cIfLRHKn56Q9eGLg0IMzcc8MiAO MBr+YdTOrCy2We2dTlXfDnbNwmm582bhnn6iOlPY5RSIacLhnBuK+DdR22fUwuXQP0 N1UY7QoOcDuWzgBg201DHlnLGb1CTSo4wLgNg9lJYmlqrFhpYTJBOWi1gjYf68l28+ cSp5H5BVsu1v+P6hskX8HYLCzadfrpX/jVZqHfWZ2u+jMxvjpET9odm57F6+YAI7SB rVmXtHwMQIJhw== References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-38-maxime@cerno.tech> User-agent: mu4e 1.6.5; emacs 27.2 From: Felipe Balbi To: Maxime Ripard Cc: devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v2 37/52] dt-bindings: usb: dwc3: Fix usb-phy check Date: Wed, 01 Sep 2021 15:36:35 +0300 In-reply-to: <20210901091852.479202-38-maxime@cerno.tech> Message-ID: <87a6kwcvzb.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_053749_987852_B86E9BDA X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Maxime Ripard writes: > The original binding was allowing any combination of usb2-phy and > usb3-phy in the phys and phy-names properties. > > However, the current binding enforces that those properties must be a > list of usb2-phy and usb3-phy, with exactly one element, effectively > making usb2-phy the only value being valid. > > Let's rework the properties description to allow either one or two > element picked with values either usb2-phy or usb3-phy. The rest of the > tooling makes sure that we don't get any duplicate value, so this should > be what we want. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 078fb7889593..c1c970073681 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -73,15 +73,15 @@ properties: > > phys: > minItems: 1 > - items: > - - description: USB2/HS PHY > - - description: USB3/SS PHY > + maxItems: 2 I'm not sure you should enforce a maximum of 2 PHYs. Some systems may use more than one USB2 PHY to take care of different parts of the USB link. IIRC N900 was a USB2-only system which shipped with two USB2 PHYs: one handling the communication proper and one handling charger detection and the like. -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel