From mboxrd@z Thu Jan 1 00:00:00 1970 From: kvalo@codeaurora.org (Kalle Valo) Date: Thu, 30 Jun 2016 12:58:14 +0300 Subject: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name dt property In-Reply-To: (Hans de Goede's message of "Thu, 30 Jun 2016 11:50:01 +0200") References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> <6402170.5s0abZDqlD@wuerfel> <1467230078.2598.2.camel@plaes.org> <87eg7f6odi.fsf@kamboji.qca.qualcomm.com> Message-ID: <87a8i36ls9.fsf@kamboji.qca.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hans de Goede writes: > Hi, > > On 30-06-16 11:02, Kalle Valo wrote: >> Priit Laes writes: >> >>>> What is the size of this nvram file? As it's board specific, I wonder >>>> if we can simply include it inside of the DT verbatim. I remember >>>> doing that (in the pre-dtb days, on real open firmware) for the >>>> "spidernet" >>>> ethernet driver. >>> >>> It contains a bit too much info: >>> >>> This is what CubieTruck requires: >>> >>> http://dl.cubieboard.org/public/Cubieboard/benn/firmware/ap6210/nvram_ap6210.txt >> >> In the nvram file I see lots of identifiers: >> >> manfid=0x2d0 >> prodid=0x492 >> vendid=0x14e4 >> devid=0x4343 >> boardtype=0x0598 >> boardrev=0x1307 >> boardnum=777 >> >> Are any of these (or a combination of them) unique for each board type? >> What if one of these is provided through DT and then the driver could >> choose the nvram file based on the board id? Just another idea... > > That would require updating a table in the driver every time a new > board comes out, I do not believe that that is a good solution. You don't necessarily need to have a table in the driver if you embed the id to the filename, for example something like this: nvram-0598-1307.txt nvram--.txt -- Kalle Valo