linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] Add support for pxa27x device-tree machine
Date: Mon, 03 Nov 2014 08:32:57 +0100	[thread overview]
Message-ID: <87a94891sm.fsf@free.fr> (raw)
In-Reply-To: <1830013.l3PUsHBfsL@wuerfel> (Arnd Bergmann's message of "Thu, 30 Oct 2014 08:07:52 +0100")

Arnd Bergmann <arnd@arndb.de> writes:

> On Thursday 30 October 2014 07:55:48 Robert Jarzmik wrote:
> Whole series
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd.

Unfortunately my checkers caught a flaw in the non-device tree case :
 - pxa27x_dt_init_irq() is defined, even if unused
 - it calls pxa_dt_irq_init(), which is conditionaly defined on CONFIG_OF
   => breaks non DT builds

So I'll have to enclose this function in a #if defined(CONFIG_OF), and respin
patch 1.

Cheers.

-- 
Robert

  reply	other threads:[~2014-11-03  7:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 15:28 [PATCH v2 0/4] Add support for pxa27x device-tree machine Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 1/4] arm: pxa: add device-tree irq init for pxa27x Robert Jarzmik
2014-10-13 10:34   ` Mark Rutland
2014-10-13 18:18     ` Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 2/4] arm: pxa: move init functions into generic.h Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 3/4] arm: pxa: remove unecessary includes from pxa-dt Robert Jarzmik
2014-10-12 15:28 ` [PATCH v2 4/4] arm: pxa: add pxa27x device-tree support Robert Jarzmik
2014-10-30  6:55 ` [PATCH v2 0/4] Add support for pxa27x device-tree machine Robert Jarzmik
2014-10-30  7:07   ` Arnd Bergmann
2014-11-03  7:32     ` Robert Jarzmik [this message]
2014-11-03 10:11       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a94891sm.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).