From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: build warnings: multi_v7_defconfig + LPAE, printk with variable types
Date: Wed, 21 Aug 2013 16:51:18 -0700 [thread overview]
Message-ID: <87a9kaob61.fsf@linaro.org> (raw)
In-Reply-To: <CAOMZO5C44GRnTs+Oq9tCJ-mtH-9kyjMqEQWRDVadDfgOOSwaLA@mail.gmail.com> (Fabio Estevam's message of "Wed, 21 Aug 2013 12:50:16 -0300")
Fabio Estevam <festevam@gmail.com> writes:
> On Wed, Aug 21, 2013 at 12:15 PM, Kevin Hilman <khilman@linaro.org> wrote:
>> [1]
>> Warnings:
>> arch/arm/mach-omap2/gpmc.c:1495:4: warning: format '%x'
>> expects argument of type 'unsigned int', but argument 4 has type
>> resource_size_t' [-Wformat]
>
> For this warning, what about this?
>
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1491,8 +1491,8 @@ static int gpmc_probe_generic_child(struct
> platform_device *pdev,
> */
> ret = gpmc_cs_remap(cs, res.start);
> if (ret < 0) {
> - dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%x\n",
> - cs, res.start);
> + dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%pa\n",
> + cs, &res.start);
hmm, why did you add the '&' ? That changes the behavior, not just the
format.
Kevin
next prev parent reply other threads:[~2013-08-21 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 15:15 build warnings: multi_v7_defconfig + LPAE, printk with variable types Kevin Hilman
2013-08-21 15:25 ` Fabio Estevam
2013-08-21 15:49 ` Kevin Hilman
2013-08-21 15:52 ` Fabio Estevam
2013-08-21 15:50 ` Fabio Estevam
2013-08-21 23:51 ` Kevin Hilman [this message]
2013-08-22 0:12 ` Russell King - ARM Linux
2013-08-22 0:21 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9kaob61.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox