From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] davinci: da8xx/omap-l1: Remove hard coding of rtc device wakeup
Date: Mon, 01 Jul 2013 17:07:43 -0700 [thread overview]
Message-ID: <87a9m5omcw.fsf@linaro.org> (raw)
In-Reply-To: <1372412109-986-3-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:07 +0530")
Hebbar Gururaja <gururaja.hebbar@ti.com> writes:
> Since now rtc-omap driver itself calls deice_init_wakeup(dev, true),
> duplicate call from the rtc device registration can be removed.
>
> This is basically a partial revert of the prev commit
>
> commit 75c99bb0006ee065b4e2995078d779418b0fab54
> Author: Sekhar Nori <nsekhar@ti.com>
>
> davinci: da8xx/omap-l1: mark RTC as a wakeup source
>
> Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
>
> ---
> :100644 100644 bf57252... 85a900c... M arch/arm/mach-davinci/devices-da8xx.c
> arch/arm/mach-davinci/devices-da8xx.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c
> index bf57252..85a900c 100644
> --- a/arch/arm/mach-davinci/devices-da8xx.c
> +++ b/arch/arm/mach-davinci/devices-da8xx.c
> @@ -827,14 +827,7 @@ static struct platform_device da8xx_rtc_device = {
>
> int da8xx_register_rtc(void)
> {
> - int ret;
> -
> - ret = platform_device_register(&da8xx_rtc_device);
> - if (!ret)
> - /* Atleast on DA850, RTC is a wakeup source */
> - device_init_wakeup(&da8xx_rtc_device.dev, true);
> -
> - return ret;
> + return platform_device_register(&da8xx_rtc_device);
nit: extra space between 'return' and 'platform_'
> }
>
> static void __iomem *da8xx_ddr2_ctlr_base;
Otherwise,
Acked-by: Kevin Hilman <khilman@linaro.org>
next prev parent reply other threads:[~2013-07-02 0:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 9:35 [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Hebbar Gururaja
2013-06-28 9:35 ` [PATCH 1/4] rtc: omap: restore back (hard-code) wakeup support Hebbar Gururaja
2013-07-02 0:06 ` Kevin Hilman
2013-06-28 9:35 ` [PATCH 2/4] davinci: da8xx/omap-l1: Remove hard coding of rtc device wakeup Hebbar Gururaja
2013-06-28 10:14 ` Manjunathappa, Prakash
2013-07-02 0:07 ` Kevin Hilman [this message]
2013-07-02 5:20 ` Hebbar, Gururaja
2013-07-02 5:40 ` Sekhar Nori
2013-07-02 5:41 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Hebbar Gururaja
2013-07-02 0:15 ` Kevin Hilman
2013-07-02 5:20 ` Hebbar, Gururaja
2013-07-02 6:02 ` Sekhar Nori
2013-07-02 6:04 ` Hebbar, Gururaja
2013-07-02 6:09 ` Sekhar Nori
2013-07-02 6:11 ` Hebbar, Gururaja
2013-07-02 6:16 ` Sekhar Nori
2013-07-03 5:03 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility Hebbar Gururaja
2013-07-02 6:12 ` Sekhar Nori
2013-07-02 6:14 ` Hebbar, Gururaja
2013-07-02 6:19 ` Hebbar, Gururaja
2013-07-03 8:12 ` Sekhar Nori
2013-07-02 0:18 ` [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9m5omcw.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).