public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: omap: fix the overrun case
Date: Fri, 21 Sep 2012 07:18:54 -0700	[thread overview]
Message-ID: <87a9wjfohd.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1348222976-7241-1-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Fri, 21 Sep 2012 15:52:56 +0530")

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> Overrun also causes an internal flag to be set, which disables further
> reception. Before the next frame can
> be received, the MPU must:
> ? Reset the RX FIFO.
> ? clear the internal flag.
>
> In the uart mode a dummy read is needed. Add the same.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> - functional testing on omap4sdp
> - Verified idle and suspend path hits off on beagle.

Tested-by: Kevin Hilman <khilman@ti.com>

This fixes the console hang I was seeing on 3530/Overo.

Thanks,

Kevin

>  drivers/tty/serial/omap-serial.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index a0d4460..bc22a2b 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -334,6 +334,13 @@ static unsigned int check_modem_status(struct uart_omap_port *up)
>  static void serial_omap_rlsi(struct uart_omap_port *up, unsigned int lsr)
>  {
>  	unsigned int flag;
> +	unsigned char ch = 0;
> +
> +	if (!(lsr & UART_LSR_BRK_ERROR_BITS))
> +		return;
> +
> +	if (likely(lsr & UART_LSR_DR))
> +		ch = serial_in(up, UART_RX);
>  
>  	up->port.icount.rx++;
>  	flag = TTY_NORMAL;

  parent reply	other threads:[~2012-09-21 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 10:22 [PATCH] serial: omap: fix the overrun case Shubhrajyoti D
2012-09-21 11:00 ` Felipe Balbi
2012-09-21 11:16   ` Shubhrajyoti
2012-09-21 11:35     ` Felipe Balbi
2012-09-21 11:48       ` Shubhrajyoti Datta
2012-09-21 11:39   ` Poddar, Sourav
2012-09-21 12:07     ` Felipe Balbi
2012-09-21 11:18 ` Poddar, Sourav
2012-09-21 14:18 ` Kevin Hilman [this message]
2012-09-21 15:08   ` Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9wjfohd.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox