From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA767CE7A89 for ; Sat, 23 Sep 2023 18:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9qXz/ZDv7RBpFLfkCs3HEbQQAJqbng3DAL6B+aNY+uE=; b=szMAXp+QJxWchY cYrQMe1Yo255srLzkTmACDmP4OesPbC4Jhvy3yFLxosxIFSlOCkROqRecBJuuZGRuM4+WcTCKL46G /fzpiVE0VxB+9tQvIXRI/hEK2gVuek6piC2cLE2PGp+sHNejrY1gLeuDqJQpDoWFwMKgR+952NoxF /teMib6hizqiTF/C88yz1oMCuDTqxdyjsoEzlEDpfe+pJMWJ8uHHwabfSZK9NeI3RQ9nFcl2Th3qM nuo38ErURx3glxwv0FHNpMrcDBFRGKi56JsJt4ET11kRRfCMTzfRc6KPWxRSs3nEiW8Lo+CkuLenk odxkfB2dIqmOlN3VvF2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qk74f-00BJ8G-0e; Sat, 23 Sep 2023 18:09:49 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qk74d-00BJ7a-10 for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2023 18:09:48 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4053c6f0d55so31564045e9.0 for ; Sat, 23 Sep 2023 11:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695492586; x=1696097386; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l0OmVT82kVRhT6V7fBBibLFNJi2iRMus/lOyy9oKOW0=; b=K8jkLuT0nss5jEp83TQww6quRCKEbDGg/rSi+fPIXtiQjhF+ZfJIYjFbmHh3VXhCf+ VaiY2Ht/Zc1vSSlBE8VwupAC+xLOANqimDINcQ5zUaCFcnVzRuWGKWrDegns6L2j/nfg miJKrz8Rb9+I4+PRLrXuRv0K6sgebmQS3lKkihjeNIvfU40zG8dr+KFsyLe8uVM6qjLa WW3K9yO8PudtkfiO/KXgLn3i9jjGK01Z/fmK+A2F3YMOsNsXnB9oZr9cto4WrwNsfPCB cLwgz2sV8iQBf+jISF7GYX1mCzz3Eo2IliX/F1Dc3dRzNvJAsSSnHxstMkewaazQqpkP 8ArA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695492586; x=1696097386; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l0OmVT82kVRhT6V7fBBibLFNJi2iRMus/lOyy9oKOW0=; b=PT6Y2i/Bz1U3obfsE2Zj/PqWq2Xz9pZ3QdW34uUF6U+QLL7uKNtc+qr0VBS7Q7dQfC Gb0A+Cal1X2lBsNVxPF7gW1ZN7OC+PsNEiygvsjshMH6nUg1LHL7H3pgPJtA8IS3+qf7 lUosIhG+xnDppripFRUUMludNXbNl6rMXxHq6F868aHiy9KVGqAQrYFAx7L/bVksnoVf 613XZeFG5jYTWqFmezYfUTyTVWAIRozltNHmm7iX6X6dej+INMJ5d6q5tOyqZa1K/M4S en3G2xELCSTfeBozbfVEy3bFBrR3RBEtUSsLqw2hx/W7DvneDXClvLGPMSri/iAz3te5 EQUQ== X-Gm-Message-State: AOJu0YwAtkLDtm0b+kI/I0FRMPRuiGpKii+M4LCCGBccmky3bS3BUBkZ AXoHlyOOlFgvqNVFN3HoGFiwGA== X-Google-Smtp-Source: AGHT+IGbEDdCor3uAVvI6RHkOnvfxXv6QO0vC7iRLExeI+9NeOdG9D895dHQs60CsZTG3e2Zoj0+KA== X-Received: by 2002:a5d:4c85:0:b0:321:5d87:5f7c with SMTP id z5-20020a5d4c85000000b003215d875f7cmr2665873wrs.30.1695492586036; Sat, 23 Sep 2023 11:09:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id z12-20020a5d654c000000b0032148618cc4sm7447722wrv.29.2023.09.23.11.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Sep 2023 11:09:45 -0700 (PDT) Message-ID: <87ae80c0-a09b-3642-e3e9-c753cd330bca@linaro.org> Date: Sat, 23 Sep 2023 20:09:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 13/15] mailbox: mediatek: Add mt8188 support for CMDQ secure driver Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno Cc: Conor Dooley , Jason-ch Chen , Johnson Wang , Elvis Wang , Singo Chang , Nancy Lin , Shawn Sung , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230918192204.32263-1-jason-jh.lin@mediatek.com> <20230918192204.32263-14-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230918192204.32263-14-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_110947_357127_3D50C014 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/09/2023 21:22, Jason-JH.Lin wrote: > Add mt8188 support for CMDQ secure driver. > > Signed-off-by: Jason-JH.Lin > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 3940b9f8e774..4e047dc916b9 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -750,6 +750,7 @@ static const struct gce_plat gce_plat_v8 = { > .thread_nr = 32, > .shift = 3, > .control_by_sw = true, > + .has_sec = true, No, you just added it patch ago. Do not add broken code and fix it. Are there some KPIs in Mediatek to have patch count? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel