From: Collin Funk <collin.funk1@gmail.com>
To: James Clark <james.clark@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Nick Terrell <terrelln@fb.com>, David Sterba <dsterba@suse.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [PATCH] perf test: Change all remaining #!/bin/sh to #!/bin/bash
Date: Mon, 23 Jun 2025 18:29:15 -0700 [thread overview]
Message-ID: <87bjqehqqc.fsf@gmail.com> (raw)
In-Reply-To: <20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org>
James Clark <james.clark@linaro.org> writes:
> There are 43 instances of posix shell tests and 35 instances of bash. To
> give us a single consistent language for testing in, replace
> all #!/bin/sh to #!/bin/bash. Common sources that are included in both
> different shells will now work as expected. And we no longer have to fix
> up bashisms that appear to work when someone's system has sh symlinked
> to bash, but don't work on other systems that have both shells
> installed.
>
> Although we could have chosen sh, it's not backwards compatible so it
> wouldn't be possible to bulk convert without re-writing the existing
> bash tests.
>
> Choosing bash also gives us some nicer features including 'local'
> variable definitions and regexes in if statements that are already
> widely used in the tests.
>
> It's not expected that there are any users with only sh available due to
> the large number of bash tests that exist.
>
> Discussed in relation to running shellcheck here:
> https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/
>
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> tools/perf/tests/perf-targz-src-pkg | 2 +-
> tools/perf/tests/shell/amd-ibs-swfilt.sh | 2 +-
> tools/perf/tests/shell/buildid.sh | 2 +-
> tools/perf/tests/shell/coresight/asm_pure_loop.sh | 2 +-
> tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh | 2 +-
> tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh | 2 +-
> tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh | 2 +-
> tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh | 2 +-
> tools/perf/tests/shell/diff.sh | 2 +-
> tools/perf/tests/shell/ftrace.sh | 2 +-
> tools/perf/tests/shell/lib/perf_has_symbol.sh | 2 +-
> tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
> tools/perf/tests/shell/lib/setup_python.sh | 2 +-
> tools/perf/tests/shell/lib/waiting.sh | 2 +-
> tools/perf/tests/shell/list.sh | 2 +-
> tools/perf/tests/shell/lock_contention.sh | 2 +-
> tools/perf/tests/shell/perf-report-hierarchy.sh | 2 +-
> tools/perf/tests/shell/probe_vfs_getname.sh | 2 +-
> tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
> tools/perf/tests/shell/record+script_probe_vfs_getname.sh | 2 +-
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
> tools/perf/tests/shell/record_bpf_filter.sh | 2 +-
> tools/perf/tests/shell/record_offcpu.sh | 2 +-
> tools/perf/tests/shell/record_sideband.sh | 2 +-
> tools/perf/tests/shell/script.sh | 2 +-
> tools/perf/tests/shell/stat+csv_summary.sh | 2 +-
> tools/perf/tests/shell/stat+shadow_stat.sh | 2 +-
> tools/perf/tests/shell/stat_all_pfm.sh | 2 +-
> tools/perf/tests/shell/stat_bpf_counters.sh | 2 +-
> tools/perf/tests/shell/stat_bpf_counters_cgrp.sh | 2 +-
> tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
> tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
> tools/perf/tests/shell/test_arm_coresight_disasm.sh | 2 +-
> tools/perf/tests/shell/test_arm_spe.sh | 2 +-
> tools/perf/tests/shell/test_arm_spe_fork.sh | 2 +-
> tools/perf/tests/shell/test_bpf_metadata.sh | 2 +-
> tools/perf/tests/shell/test_intel_pt.sh | 2 +-
> tools/perf/tests/shell/trace+probe_vfs_getname.sh | 2 +-
> tools/perf/tests/shell/trace_btf_enum.sh | 2 +-
> tools/perf/tests/shell/trace_exit_race.sh | 2 +-
> tools/perf/tests/shell/trace_record_replay.sh | 2 +-
> tools/perf/tests/shell/trace_summary.sh | 2 +-
> tools/perf/tests/tests-scripts.c | 2 +-
> 43 files changed, 43 insertions(+), 43 deletions(-)
Patch looks good to me.
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Collin
next prev parent reply other threads:[~2025-06-24 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 9:00 [PATCH] perf test: Change all remaining #!/bin/sh to #!/bin/bash James Clark
2025-06-24 1:29 ` Collin Funk [this message]
2025-06-25 19:28 ` Arnaldo Carvalho de Melo
2025-06-26 17:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjqehqqc.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=coresight@lists.linaro.org \
--cc=dsterba@suse.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).