From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F28C3DA7F for ; Thu, 15 Aug 2024 09:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NZcnI7lILk4yJLsu6xoOTUfb8bUCsnMsqdBFy+TyUBc=; b=J8iCTzvfk6kQCweQ+yUdo533PB kSwu+a+GRU5W2U3j/JzECzO/2V7xCSMEd02NsrMCFzyOEMFU0fz9imWYEMamL1NGiZ4WQ+QZXBY0q xyIsO1zqBoQWyxrt3Ihth9xliqnpataQ3WGDAU6skg8bypzEOFf2Jwo1QeQ06A6AyX8BHoPqBA7Y7 kWiW5zRNt6CelPNGApdX7AbvZTOedMZRmRarpLvINizMc5KUvH1QuRxp9AerjN8IaYbciJb7vrOj+ hV8vEDK6fg3OPpNj3NWvb0SjOdwMNmqifG0GSsPJpnZIxUqjVQGPBWyN3OqIiJeH4VMWFUCmttnsg A+tAiaVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seWxE-00000009VDi-0n7r; Thu, 15 Aug 2024 09:39:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seWwZ-00000009V9w-1onq; Thu, 15 Aug 2024 09:38:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1872561D51; Thu, 15 Aug 2024 09:38:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF34C32786; Thu, 15 Aug 2024 09:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723714728; bh=sHvQeaXALSod3ueM8ffo2GB1iY9rKy6DqW6c+tre7Eg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=un1AGHtTQkIq8l2baWkpOvK8FoMjlipyROLzC48SvoWBv+3U/pSjfXUoUXLVspXz+ STZiaI/a6Tmy7tdCNHdOEfyrDj0aVkP/Sw/QvvmJ6mtOMiQcrdUIGFC0iwsGTU/V4Y 9J5nxrc+9mOni7qLmZwWbOvnlgiJbIxurtIcb2upt5emhELjSVFdG3kJ/pw6Ssbe2s DRKVy7RoeXJjZK1NanCK5B+xkwSfi3I0hVR+h2zlTuP4m67u4Oa0aGj4+3bcvy/NBj xFGqEPrCi5A7r4J/U3Q6RSxtAXJuUwF4P9iKf5E3p7E69IQ31AEhj7zPmjx7J4miQH Kb8SqKyVfFYYg== From: Kalle Valo To: Arend Van Spriel Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Jacobe Zang , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v10 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d References: <20240813082007.2625841-1-jacobe.zang@wesion.com> <20240813082007.2625841-2-jacobe.zang@wesion.com> <1914cb2b1a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <062d8d4e-6d61-4f11-a9c0-1bbe1bfe0542@broadcom.com> <1e442710-a233-4ab2-a551-f28ba6394b5b@linaro.org> <180f7459-39fa-4e96-83d6-504e7802dc94@broadcom.com> <19151c92b40.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Date: Thu, 15 Aug 2024 12:38:40 +0300 In-Reply-To: <19151c92b40.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Wed, 14 Aug 2024 18:47:04 +0200") Message-ID: <87bk1uyvkv.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_023855_580737_33008B05 X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arend Van Spriel writes: > On August 14, 2024 4:08:52 PM Krzysztof Kozlowski > wrote: > >> On 14/08/2024 13:15, Krzysztof Kozlowski wrote: >>> On 14/08/2024 12:59, Arend van Spriel wrote: >>>> On 8/14/2024 12:39 PM, Krzysztof Kozlowski wrote: >>>>> On 14/08/2024 12:08, Arend van Spriel wrote: >>>>>> On 8/14/2024 10:53 AM, Krzysztof Kozlowski wrote: >>>>>>> On 13/08/2024 19:04, Arend Van Spriel wrote: >>>>>>>> On August 13, 2024 10:20:24 AM Jacobe Zang wrote: >>>>>>>> >>>>>>>>> It's the device id used by AP6275P which is the Wi-Fi module >>>>>>>>> used by Rockchip's RK3588 evaluation board and also used in >>>>>>>>> some other RK3588 boards. >>>>>>>> >>>>>>>> Hi Kalle, >>>>>>>> >>>>>>>> There probably will be a v11, but wanted to know how this series will be >>>>>>>> handled as it involves device tree bindings, arm arch device tree spec, and >>>>>>>> brcmfmac driver code. Can it all go through wireless-next? >>>>>>> >>>>>>> No, DTS must not go via wireless-next. Please split it from the series >>>>>>> and provide lore link in changelog for bindings. >>>>>> >>>>>> Hi Krzysztof, >>>>>> >>>>>> Is it really important how the patches travel upstream to Linus. This >>>>>> binding is specific to Broadcom wifi devices so there are no >>>>>> dependencies(?). To clarify what you are asking I assume two separate >>>>>> series: >>>>>> >>>>>> 1) DT binding + Khadas Edge2 DTS -> devicetree@vger.kernel.org >>>>>> reference to: >>>>>> https://patch.msgid.link/20240813082007.2625841-1-jacobe.zang@wesion.com >>>>>> >>>>>> 2) brcmfmac driver changes -> linux-wireless@vger.kernel.org >>>>> >>>>> No. I said only DTS is separate. This was always the rule, since forever. >>>>> >>>>> Documentation/devicetree/bindings/submitting-patches.rst >>>> >>>> I am going slightly mad (by Queen). That documents says: >>>> >>>> 1) The Documentation/ and include/dt-bindings/ portion of the patch >>>> should >>>> be a separate patch. >>>> >>>> and >>>> >>>> 4) Submit the entire series to the devicetree mailinglist at >>>> >>>> devicetree@vger.kernel.org >>>> >>>> Above I mentioned "series", not "patch". So 1) is a series of 3 patches >>>> (2 changes to the DT binding file and 1 patch for the Khadas Edge2 DTS. >>>> Is that correct? >>> >>> My bookmark to elixir.bootling does not work, so could not paste >>> specific line. Now it works, so: >>> >>> https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L79 >>> >>> The rule was/is: >>> 1. Binding for typical devices always go via subsystem tree, with the >>> driver changes. >>> There can be exceptions from above, e.g. some subsystems do not pick up >>> bindings, so Rob does. But how patches are organized is not an exception >>> - it is completely normal workflow. >>> >>> 2. DTS *always* goes via SoC maintainer. DTS cannot go via any other >>> driver subsystem tree. There is no exception here. There cannot be an >>> exception, because it would mean the hardware depends on driver, which >>> is obviously false. >> >> In case my message was not clear: we talk here about organizing >> patchsets, not individual patches. If you ask about patches, then DTS, >> bindings and driver are all separate patches. This set already is split >> like that, so this was fine and I did not comment on it. Only through >> whom the DTS patch goes - separate tree. > > I used the "series" which is my term for "patchset". Sorry for > confusion. So "[PATCH 3/5] arm64: dts: rockchip: Add AP6275P wireless > support to Khadas Edge 2" should be submitted to rockchip soc related > tree and the rest can go through the wireless-next tree. Got it. Yes, this is how we have done before as well. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches