From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E4AAC54E64 for ; Mon, 25 Mar 2024 17:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kqbu24Iy2ES0GWBVDRiAAHecnHMp/tNEocK6nzyJP/Q=; b=dlJitSw9owWZt4 VnjS2AiAmqZ/PIR9QdwiXu0qi8t4vctt5NefObMJ/HxePJ09SDjTdvWSKezJU7l6nzh0zqFKsPHDY i/BmUKPT9/qdPYGr+KrZr2wctYzd0XKIn4DeLV5Yp3o4UfC2AccRxkO31qCpcU53UMRq0ajYwik2D 7R/4k9ALA2+OHPoGKtJMrtMtmo6Isspg3JGlYlP4bXn9PMPwqDLEHMaTGIxo/UCdPCnulOUr8PwhW vjISbzz1+VfNUPh4CYdcEo5N56NYVS1VfI99Ag3Jtagy/B3f1ZorDBgsynJXSB6+FrACd+/u5gU6u isyqL6s8yneEXIrxQjOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roo8N-0000000132B-1EjL; Mon, 25 Mar 2024 17:29:20 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roo8F-000000012wo-2VQG for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 17:29:16 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1711387743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DK75XUtlMLk9/6ARSoFxcVcx+16IzV8AtSC+x6vyvg0=; b=D6f93+ZwVXOucjhz90HFPRG8UrmlmLHw5luAhexA228uzsatRdCZEo6Cf0rgIb3vIf4Yv5 WBn4yUi8Vs53n1nP2RcYibCv+Ry9Lz56+lIzphC8B1gp+QICHV0oXc+P0gpn4PfZM8ZL/j Opsz07yxMw4nNK1+fGJa+XNfvb3C2s6kSoCK329vxCJBdVBPAesaYWUJleFB6NAAbWwviI QdqOt5MXbqv3MplJ5ZaQ5hw4BdX6wbibi4eWU9oAXMxw/T8jiN2VFIIjeHgA0g5e0NNuaU 5sN2nDBcIOa/9Rk60SYId7qHKjaJEMY4wtq1mtTlfo+qKqiYTxNPLAXNdy/3aw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1711387743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DK75XUtlMLk9/6ARSoFxcVcx+16IzV8AtSC+x6vyvg0=; b=ADqaJtSTgua0QpmlQ9S4WNkb+UhTfDqmg9pUgccPc2/fxJseO/HvWkPVtOMfNJ7AGF035A VdvNBAQgh8+vNcCQ== To: Jason Gunthorpe , "Peng Fan (OSS)" Cc: Will Deacon , Robin Murphy , Joerg Roedel , Marc Zyngier , Bixuan Cui , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume In-Reply-To: <20240325134848.GA8419@ziepe.ca> References: <20240324-smmu-v3-v1-0-11bc96e156a5@nxp.com> <20240324-smmu-v3-v1-3-11bc96e156a5@nxp.com> <20240325134848.GA8419@ziepe.ca> Date: Mon, 25 Mar 2024 18:29:03 +0100 Message-ID: <87bk72fcf4.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_102911_838668_92510F0B X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25 2024 at 10:48, Jason Gunthorpe wrote: > On Sun, Mar 24, 2024 at 08:29:00PM +0800, Peng Fan (OSS) wrote: >> +static void arm_smmu_resume_unique_irqs(struct arm_smmu_device *smmu) >> +{ >> + struct device *dev = smmu->dev; >> + struct msi_desc *desc; >> + struct msi_msg msg; >> + >> + if (!dev->msi.domain) >> + return; >> + >> + desc = irq_get_msi_desc(smmu->evtq.q.irq); >> + if (desc) { >> + get_cached_msi_msg(smmu->evtq.q.irq, &msg); >> + arm_smmu_write_msi_msg(desc, &msg); >> + } >> + >> + desc = irq_get_msi_desc(smmu->gerr_irq); >> + if (desc) { >> + get_cached_msi_msg(smmu->gerr_irq, &msg); >> + arm_smmu_write_msi_msg(desc, &msg); >> + } >> + >> + if (smmu->features & ARM_SMMU_FEAT_PRI) { >> + desc = irq_get_msi_desc(smmu->priq.q.irq); >> + if (desc) { >> + get_cached_msi_msg(smmu->priq.q.irq, &msg); >> + arm_smmu_write_msi_msg(desc, &msg); >> + } >> + } >> +} > > I wonder if this should be done instead by converting the driver away > from platform MSI to the new MSI mechanism? There is work in progress for that. Should come around in the next weeks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel