From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1A1C4332F for ; Sun, 5 Nov 2023 08:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E80gcdzsOTi9aEBkbIyR8IHL3qcqviWKn1i5gq7Z9KY=; b=oPkSVulMDTG2Au VvG9RhFnMRQpWC2qpfF8K2DyiBjRrCzC1pD2RUi1DeRDSpe6hrklQpbbwFtK5F+GuF6Gg23tFzRHB ZF/YV5cs521jX3q7ThLZDN6CWfN9bKpqcPVlLUWeH2UIYX8JY2SHw4Vi7pEe7Xt5BTqRdEq6YDwQz Ghysvuy5tPg+5okn5EAdjxRIZ1cFBdQTKgJlbx1ZM8i+Ard1C/JmkwYNd2UlWMAQmZl7nQNf+A532 WWU4yXeTp6bi1nQHnEXI2tyugilpkVDfX+0qiM7WhgY9QTxTGhRj5/BmITCRiIDKdnnBQzidi/ZB6 mku31NjAgYcmguWxYEfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzYuh-00EdX5-1l; Sun, 05 Nov 2023 08:55:23 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzYue-00EdW4-2M for linux-arm-kernel@lists.infradead.org; Sun, 05 Nov 2023 08:55:22 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1699174512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+scDlDhNhkUPIshK5XB+h8FHetyDO/Mc6Boo17zPpg=; b=dG37TWZuavaMQfosqPxCDLUlRQFhum2NYQtMTSKFCDwpKzsZ+IL7MZ6lWvAgHDUNCoQfDU 3NwVsIMb1SX/empXV4zoXTIPCtniuOXkY7unTGEplkcJlKgIL9553VIBu85Oaycj1ZNNel PiWXTfL59detwIW1Rmd0xGTMCX84nirgLwZXCYJ0GylH7DekZddZoE6nQfTRmCeBxAMXpI kzpRyMrzBREziXcHBFV041C+3x/aSulY7GE+H0gpHL2EWz6kNHUCG9Q/xDY0WiJVFPnoUX qFwp65ENeOjDYroIb2hUW4S7yHe2NbdiZW6dM4aaEDamxXqE8l0cFSZY34Ww8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1699174512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+scDlDhNhkUPIshK5XB+h8FHetyDO/Mc6Boo17zPpg=; b=q7GAEMPYyQ0uAcTxscpbCQH3x3bU4xe6KMBPB8vGkNgoScg5KE5PIDTjM0/M/av27nmqRe teReQ6U6yEm58kBg== To: Marc Zyngier , Fang Xiang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4] irqchip/gic-v3-its: Flush ITS tables before writing GITS_BASER registers in non-coherent GIC designs. In-Reply-To: <87o7g96duv.wl-maz@kernel.org> References: <20231030083256.4345-1-fangxiang3@xiaomi.com> <87o7g96duv.wl-maz@kernel.org> Date: Sun, 05 Nov 2023 09:55:11 +0100 Message-ID: <87bkc8inps.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231105_015520_918134_6CDC3FD0 X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 04 2023 at 09:56, Marc Zyngier wrote: > On Mon, 30 Oct 2023 08:32:56 +0000, > Fang Xiang wrote: >> >> In non-coherent GIC design, ITS tables should be clean and flushed >> to the PoV of the ITS before writing GITS_BASER registers, otherwise >> the ITS would read dirty tables and lead to UNPREDICTABLE behaviors. >> >> The ITS always got clean tables in initialization with this fix, by >> observing the signals from GIC. >> >> Furthermore, hoist the quirked non-shareable attributes earlier to >> save effort in tables setup. >> >> Suggested-by: Marc Zyngier >> Signed-off-by: Fang Xiang >> Tested-by: Fang Xiang > > Reviewed-by: Marc Zyngier Shouldn't this have a Fixes tag? My guess is: a8707f553884 ("irqchip/gic-v3: Add Rockchip 3588001 erratum workaround") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel