linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
  • [parent not found: <20230512205257.411554373@linutronix.de>]
  • * [PATCH] x86/apic: Fix use of X{,2}APIC_ENABLE in asm with older binutils
           [not found] <20230512203426.452963764@linutronix.de>
           [not found] ` <20230512205257.467571745@linutronix.de>
           [not found] ` <20230512205257.411554373@linutronix.de>
    @ 2023-05-22 10:57 ` Andrew Cooper
      2023-05-22 11:17   ` Russell King (Oracle)
           [not found] ` <20230512205257.240231377@linutronix.de>
                       ` (3 subsequent siblings)
      6 siblings, 1 reply; 14+ messages in thread
    From: Andrew Cooper @ 2023-05-22 10:57 UTC (permalink / raw)
      To: tglx
      Cc: James.Bottomley, andrew.cooper3, arjan, arnd, boris.ostrovsky,
    	brgerst, catalin.marinas, deller, dwmw2, gpiccoli, guoren, jgross,
    	linux-arm-kernel, linux-csky, linux-kernel, linux-mips,
    	linux-parisc, linux-riscv, linux, lucjan.lucjanov, mark.rutland,
    	mikelley, oleksandr, palmer, paul.walmsley, paulmck, pbonzini,
    	pmenzel, ross.philipson, sabrapan, seanjc, thomas.lendacky,
    	tsbogend, usama.arif, will, x86, xen-devel, Jeffrey Hugo
    
    "x86/smpboot: Support parallel startup of secondary CPUs" adds the first use
    of X2APIC_ENABLE in assembly, but older binutils don't tolerate the UL suffix.
    
    Switch to using BIT() instead.
    
    Fixes: 7e75178a0950 ("x86/smpboot: Support parallel startup of secondary CPUs")
    Reported-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
    Tested-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    ---
     arch/x86/include/asm/apicdef.h | 6 ++++--
     1 file changed, 4 insertions(+), 2 deletions(-)
    
    diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
    index bf546dfb6e58..4b125e5b3187 100644
    --- a/arch/x86/include/asm/apicdef.h
    +++ b/arch/x86/include/asm/apicdef.h
    @@ -2,6 +2,8 @@
     #ifndef _ASM_X86_APICDEF_H
     #define _ASM_X86_APICDEF_H
     
    +#include <linux/bits.h>
    +
     /*
      * Constants for various Intel APICs. (local APIC, IOAPIC, etc.)
      *
    @@ -140,8 +142,8 @@
     #define APIC_BASE (fix_to_virt(FIX_APIC_BASE))
     #define APIC_BASE_MSR		0x800
     #define APIC_X2APIC_ID_MSR	0x802
    -#define XAPIC_ENABLE	(1UL << 11)
    -#define X2APIC_ENABLE	(1UL << 10)
    +#define XAPIC_ENABLE		BIT(11)
    +#define X2APIC_ENABLE		BIT(10)
     
     #ifdef CONFIG_X86_32
     # define MAX_IO_APICS 64
    
    base-commit: 0c7ffa32dbd6b09a87fea4ad1de8b27145dfd9a6
    -- 
    2.30.2
    
    
    _______________________________________________
    linux-arm-kernel mailing list
    linux-arm-kernel@lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
    
    ^ permalink raw reply related	[flat|nested] 14+ messages in thread
  • [parent not found: <20230512205257.240231377@linutronix.de>]
  • [parent not found: <20230512205255.662319599@linutronix.de>]
  • [parent not found: <20230512205255.822234014@linutronix.de>]
  • [parent not found: <20230512205255.981999763@linutronix.de>]

  • end of thread, other threads:[~2023-06-13  1:03 UTC | newest]
    
    Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
    -- links below jump to the message on this page --
         [not found] <20230512203426.452963764@linutronix.de>
         [not found] ` <20230512205257.467571745@linutronix.de>
    2023-05-15 12:00   ` [patch V4 37/37] x86/smpboot/64: Implement arch_cpuhp_init_parallel_bringup() and enable it Peter Zijlstra
         [not found] ` <20230512205257.411554373@linutronix.de>
    2023-05-19 16:28   ` [patch V4 36/37] x86/smpboot: Support parallel startup of secondary CPUs Jeffrey Hugo
    2023-05-19 16:57     ` Andrew Cooper
    2023-05-19 17:44       ` Jeffrey Hugo
    2023-05-22 10:57 ` [PATCH] x86/apic: Fix use of X{,2}APIC_ENABLE in asm with older binutils Andrew Cooper
    2023-05-22 11:17   ` Russell King (Oracle)
         [not found] ` <20230512205257.240231377@linutronix.de>
    2023-05-22 19:45   ` [patch V4 33/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE Mark Brown
    2023-05-22 21:04     ` Thomas Gleixner
    2023-05-22 22:27       ` Mark Brown
    2023-05-22 23:12         ` Thomas Gleixner
    2023-05-23 10:19           ` Mark Brown
         [not found] ` <20230512205255.662319599@linutronix.de>
    2023-06-12 23:45   ` [patch V4 04/37] x86/smpboot: Rename start_cpu0() to soft_restart_cpu() Philippe Mathieu-Daudé
         [not found] ` <20230512205255.822234014@linutronix.de>
    2023-06-12 23:46   ` [patch V4 07/37] x86/smpboot: Restrict soft_restart_cpu() to SEV Philippe Mathieu-Daudé
         [not found] ` <20230512205255.981999763@linutronix.de>
    2023-06-12 23:49   ` [patch V4 10/37] x86/smpboot: Get rid of cpu_init_secondary() Philippe Mathieu-Daudé
    

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox;
    as well as URLs for NNTP newsgroup(s).