From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 188CAC77B7F for ; Tue, 16 May 2023 19:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9QWMj1iIarMJTTU67xt4T4jA/wPQZtPRwaniW1rCqO0=; b=V1AJDFEiXx4h9q MmPT5Kmwiuf9JquGE/G1OjrbmGKLrPlYWQxqb9QqvmFLTcff6jeDqCgHW8Y9cruZQBlKaChob/sSZ HqcNLRYoMhJQiU9Z9sIqf0nKPcUVlDPGA7QjKUcJTK+9xo+wjGmTaNj6ETCL1eauh1jGpOVg9JSMD qFNAKwnCnXYCGf4Y+7XQbALlND7vpOSDliJ8YDNXGsihkx1mSH/7Tcy97PHOEAjxCPKV+Zc/cAhIZ iFRhU9ybPX1xoLB7XPJI+SbyWTQqpxXAqcEz/6dUaqNgUMQb1j5zB6sXZeQBeAVRX+Ku3LJscUyzd PuezstjUBXKFHs78aM3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pz0PU-006vKr-2h; Tue, 16 May 2023 19:32:36 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pz0PS-006vK9-11 for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 19:32:35 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684265552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i7R0serjdAd95/t2bcbDMvmqk9PuKfWQm9HVe5uYFlU=; b=ICHoW9E6IDEliSlqPAQ186Pit1ESPe++Q23Ty/56MQJ18783ff4rTHS8smkhV8kGBQhU3L Sba9Tk28GgyafPXjARMd5YP8aBLMiL1kRN62UZD7n9+kna78Fb5bSL2dDFhKlnZg7ty07m swzQO11FOK2AfzC0O843hT02TO57d2eQyb+ScHT0RvR/iDgmGv0KkmpHhATVtC9yvOeOKs y01UDqIDhMdxkkePQ6C0A4IZyPSe8GGQcsQ3IWv3iqAoMqlUf5pWHWp/93WdrJmTDqpxHO MKRrXKwmPsbgu+VsdgOE8pmc20j3rRThDthUoby23OGQ9YadQHRaNOjCZ5AaNQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684265552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i7R0serjdAd95/t2bcbDMvmqk9PuKfWQm9HVe5uYFlU=; b=5uypkhwF3F6JvIFA79fz1JDY9g9sJqnc/kgLqihD/wKYR9wvq+dSSm1eVyrFm1zXmYQvFx g1gjZ5rPyjMyLKDw== To: Nadav Amit Cc: Uladzislau Rezki , "Russell King (Oracle)" , Andrew Morton , linux-mm , Christoph Hellwig , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: Excessive TLB flush ranges In-Reply-To: <7ED917BC-420F-47D4-8956-8984205A75F0@gmail.com> References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87cz308y3s.ffs@tglx> <87y1lo7a0z.ffs@tglx> <87o7mk733x.ffs@tglx> <7ED917BC-420F-47D4-8956-8984205A75F0@gmail.com> Date: Tue, 16 May 2023 21:32:32 +0200 Message-ID: <87bkik6pin.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_123234_497412_2470D369 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 16 2023 at 10:56, Nadav Amit wrote: >> On May 16, 2023, at 7:38 AM, Thomas Gleixner wrote: >> >> There is a world outside of x86, but even on x86 it's borderline silly >> to take the whole TLB out when you can flush 3 TLB entries one by one >> with exactly the same number of IPIs, i.e. _one_. No? > > I just want to re-raise points that were made in the past, including in > the discussion that I sent before and match my experience. > > Feel free to reject them, but I think you should not ignore them. I'm not ignoring them and I'm well aware of these issues. No need to repeat them over and over. I'm old but not senile yet. It might turn out that it's not the proper solution for x86, but the generic vmalloc code as of today is written with an x86 centric view. That actively hurts other architectures which do have different constraints than x86. Any architecture which can do IPI-less TLB flushes seriously wants to decide on their own whether a flush all is the better option or not. Blindly coalescing random address ranges makes this impossible as demonstrated. Aside of that I just wrote the patch for x86 in the first place because I couldn't be bothered to find and setup an ARM box to test on. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel