From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7142C433F5 for ; Thu, 30 Sep 2021 10:25:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8557861881 for ; Thu, 30 Sep 2021 10:25:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8557861881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VG5gD7PgoCuzAKpuHj8ycdKYaFdsQu6rroEPzolP/JU=; b=ENfRAeP1OrCNAV /0tcwMoI9EldlyklmAQdskQAelObS/NVKfWyiivY6x7trk5vqToQrYzQdbaGDjMjlCUpWl0BQbQW8 Z4gzlhUISnsy+Zw0ZUEuVhecLl5P9ODFTQR2vCvOWkZFghLKr1XdZARLcL3nqGhs/vWcIKWqz83wO H5JmD7toi4NONP4f0PZJaMIoXVvJ3EHeiVi7yiNZEaGNrh7yixLsZbmo024jr5zwMMB85dDYRos5p DgZUb/DTFLoPOXO31u6Ks5qoP/h4onBFr3c+ZC8qC1RTysffjgxD/rT9yWHiER3pb+8qvAr3jUTOh TyXFVeWlQ3+rHirMgtNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVtDV-00Dna7-Di; Thu, 30 Sep 2021 10:23:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVtDR-00DnZa-J1 for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 10:23:02 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4821661881; Thu, 30 Sep 2021 10:23:01 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mVtDP-00DxDc-3r; Thu, 30 Sep 2021 11:22:59 +0100 Date: Thu, 30 Sep 2021 11:22:58 +0100 Message-ID: <87bl4atla5.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, ascull@google.com, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line In-Reply-To: References: <20210903091652.985836-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dbrazdil@google.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, ascull@google.com, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_032301_665798_1315B8F1 X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, On Tue, 28 Sep 2021 15:58:08 +0100, David Brazdil wrote: > > Hey Marc, > that all makes sense: > > Reviewed-by: David Brazdil > > > @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg) > > return 0; > > } > > > > - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) > > + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { > > + kvm_mode = KVM_MODE_DEFAULT; > > return 0; > > + } > > + > > + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { > nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for > protected it is checked in is_kvm_protected_mode. May be worth unifying? is_kvm_protected_mode() drives a capability (as we rely on the associated static key), and we don't need this with either 'nvhe' nor 'none'. So I'm unsure what we can unify, to be honest. Can you suggest a patch? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel