From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B63AC433DB for ; Tue, 30 Mar 2021 15:36:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30484619D8 for ; Tue, 30 Mar 2021 15:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30484619D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=34lHZ62DP5Ct1AAem8D9EJryqxGznenW2btrsZtqXrs=; b=Y2JBK3jYiFWnF1qrU9pkYQJG4 l1PZVxfLjmQauDgfovRaZL+xIv3UAeja1XXDVuXAd9IPsjwvPpczFCfQVv9LX5Bb4sbrTFykPGodA pmcv8KLi7F8/orKpXfc6XeRUXL/ydBDwVYY/ldyKM8SSo5pvybh52j/7sO4oZqsPPKeRX01r13B0r CbupUNpjZTR7o4anWRclkw902EiFDluGcN4Nyz21tIT1jcTwPkGIaPUFaH6Wpe1dcvcOBzU0pr/pJ IyJAPuo3VZ5Hy43in50OiIg0/cmxzWNd5yfS6fk4Bgcub23OsbUpgh9/jxfPSK0VoQF40tOa1wgGK rtiMoY6Jw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRGOQ-004DGe-Bb; Tue, 30 Mar 2021 15:34:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRGOI-004DFi-Jp for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 15:34:52 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D6E2619A7; Tue, 30 Mar 2021 15:34:49 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lRGOE-004iZ4-7z; Tue, 30 Mar 2021 16:34:46 +0100 Date: Tue, 30 Mar 2021 16:34:45 +0100 Message-ID: <87blb0r6y2.wl-maz@kernel.org> From: Marc Zyngier To: Mathieu Poirier Cc: Suzuki K Poulose , Catalin Marinas , gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, Will Deacon , Mark Rutland Subject: Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host In-Reply-To: <20210330152314.GA2329603@xps15> References: <20210323120647.454211-1-suzuki.poulose@arm.com> <20210323120647.454211-8-suzuki.poulose@arm.com> <20210326165550.GC2009902@xps15> <20210330152314.GA2329603@xps15> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, will@kernel.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_163451_169653_2E9D6B87 X-CRM114-Status: GOOD ( 40.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Mar 2021 16:23:14 +0100, Mathieu Poirier wrote: > > On Tue, Mar 30, 2021 at 11:38:18AM +0100, Suzuki K Poulose wrote: > > On 26/03/2021 16:55, Mathieu Poirier wrote: > > > On Tue, Mar 23, 2021 at 12:06:35PM +0000, Suzuki K Poulose wrote: > > > > For a nvhe host, the EL2 must allow the EL1&0 translation > > > > regime for TraceBuffer (MDCR_EL2.E2TB == 0b11). This must > > > > be saved/restored over a trip to the guest. Also, before > > > > entering the guest, we must flush any trace data if the > > > > TRBE was enabled. And we must prohibit the generation > > > > of trace while we are in EL1 by clearing the TRFCR_EL1. > > > > > > > > For vhe, the EL2 must prevent the EL1 access to the Trace > > > > Buffer. > > > > > > > > Cc: Will Deacon > > > > Cc: Catalin Marinas > > > > Cc: Marc Zyngier > > > > Cc: Mark Rutland > > > > Cc: Anshuman Khandual > > > > Acked-by: Mathieu Poirier > > > > Signed-off-by: Suzuki K Poulose > > > > --- > > > > arch/arm64/include/asm/el2_setup.h | 13 +++++++++ > > > > arch/arm64/include/asm/kvm_arm.h | 2 ++ > > > > arch/arm64/include/asm/kvm_host.h | 2 ++ > > > > arch/arm64/kernel/hyp-stub.S | 3 ++- > > > > arch/arm64/kvm/debug.c | 6 ++--- > > > > arch/arm64/kvm/hyp/nvhe/debug-sr.c | 42 ++++++++++++++++++++++++++++++ > > > > arch/arm64/kvm/hyp/nvhe/switch.c | 1 + > > > > 7 files changed, 65 insertions(+), 4 deletions(-) > > > > > > > > > > Marc - do you want me to pick up this one? > > > > I think the kvmarm tree is the best route for this patch, given the amount > > of changes the tree is going through, in the areas this patch > > touches. Or else there would be conflicts with merging. And this patch > > depends on the patches from this series that were queued. > > > > Here is the depency tree : > > > > a) kvm-arm fixes for debug (Patch 1, 2) & SPE save-restore fix (queued in > > v5.12-rc3) > > > > b) TRBE defintions and Trace synchronization barrier (Patches 5 & 6) > > > > c) kvm-arm TRBE host support (Patch 7) > > > > d) TRBE driver support (and the ETE changes) > > > > > > (c) code merge depends on -> (a) + (b) > > (d) build (no conflicts) depends on -> (b) > > > > > > Now (d) has an indirect dependency on (c) for operational correctness at > > runtime. > > So, if : > > > > kvmarm tree picks up : b + c > > coresight tree picksup : b + d > > > > and if we could ensure the merge order of the trees are in > > kvmarm > > greg-kh (device-misc tree) (coresight goes via this tree) > > > > Greg's char-misc tree is based on the rc releases rather than next. As such it > is a while before other branches like kvmarm get merged, causing all sort of > compilation breakage. > > > we should be fine. > > > > Additionally, we could rip out the Kconfig changes from the TRBE patch > > and add it only at the rc1, once we verify both the trees are in to make > > sure the runtime operation dependency is not triggered. > > > > We could also do that but Greg might frown at the tactic, and > rightly so. We do that all the times. Otherwise, it is hardly possible to build an infrastructure that spans across multiple subsystems *and* involves userspace. I really wouldn't worry about that. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel