From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458FBC433E0 for ; Mon, 8 Feb 2021 11:32:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1C1864E42 for ; Mon, 8 Feb 2021 11:32:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1C1864E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5ysekmXrYR5ij6QvwnhBikzZibSilgCYVDgI8Hilp6Q=; b=XgGGJFJzn7IwXrY7NOI3XJAcd V3jjUosDKhbasS7GaKSy2oZ+WCfsd6dgBR/lTenft6yXnJh7HDX7v4AZ0rxPznU6iJrm239XdaN6t VyH4NVDFriy6WkCtwqzyelijPXMjKoyQPWS3YUPoEsBJVTg3vMh8tSZ9z+EUClWZQSgDMBA6t+ogM qUc4dRj8CBm2YXSM7PkrVCDZv6VsOupQvQl53NikI62JHgoVT2sR+nErlrZiasJgv5YnWberXRuXe dwB7j6KWqHAbDxJ+lPTI/qrymGCCg4uBTMUiRKCjlnfy0XLMtis3hTHug3W+YolP4d4FheuX0Q7WR sF4z3pQHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94ks-0000JL-DE; Mon, 08 Feb 2021 11:30:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94kp-0000IT-Dp for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 11:30:56 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 467E164EA1; Mon, 8 Feb 2021 11:30:54 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1l94km-00ClSf-1Q; Mon, 08 Feb 2021 11:30:52 +0000 Date: Mon, 08 Feb 2021 11:30:50 +0000 Message-ID: <87blculrth.wl-maz@kernel.org> From: Marc Zyngier To: Hector Martin 'marcan' Subject: Re: [PATCH 10/18] arm64: Introduce FIQ support In-Reply-To: <2bfebb31-afb5-88a7-d092-87f88aa7367a@marcan.st> References: <20210204203951.52105-1-marcan@marcan.st> <20210204203951.52105-11-marcan@marcan.st> <87h7mpky0f.wl-maz@kernel.org> <2bfebb31-afb5-88a7-d092-87f88aa7367a@marcan.st> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: marcan@marcan.st, soc@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, arnd@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, mark.rutland@arm.com, james.morse@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_063055_557119_EFF24426 X-CRM114-Status: GOOD ( 24.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Mark Rutland , Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, soc@kernel.org, robh+dt@kernel.org, James Morse , Olof Johansson , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 07 Feb 2021 08:47:23 +0000, Hector Martin 'marcan' wrote: > > On 07/02/2021 00.37, Marc Zyngier wrote: > > See my digression in patch 8. I really wonder what the benefit is to > > treat FIQ independently of IRQ, and we might as well generalise > > this. We could always panic on getting a FIQ on platforms that don't > > expect one. > > > > It'd be good to rope in the other interested parties (Mark for the > > early entry code, James for RAS and SError handling). > > CCing Mark and James: TL;DR what do you think about unconditionally > keeping DAIF.I == DAIF.F, would this break other platforms with > spurious FIQs or conversely mask FIQs when we don't want to in some > cases? The FIQ vector would remain a panic except on platforms that > require using it, via an alternatives patch. > > >> kernel_ventry 1, sync // Synchronous EL1h > >> kernel_ventry 1, irq // IRQ EL1h > >> - kernel_ventry 1, fiq_invalid // FIQ EL1h > >> + // FIQ EL1h > >> + kernel_ventry 1, fiq_invalid, 64, irq, ARM64_NEEDS_FIQ > > > > It could be better to create a set of first class FIQ handlers rather > > than this alternative target macro. I quickly hacked this instead, > > which I find more readable. > > I think I ended up with the macro change to keep it 1:1 with IRQ, vs a > separate branch... but I didn't think of the fallthrough-with-nop > trick, neat. It is definitely is more readable. Are you OK with me > pulling this patch in for v2, with your name on it? Up to you, I don't mind either way. This is just code! :D > > > - kernel_ventry 0, fiq_invalid_compat, 32 // FIQ 32-bit EL0 > > + kernel_ventry 0, fiq, 32 // FIQ 32-bit EL0 > > fiq_compat here, right? Of course. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel