From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F053DC433E1 for ; Tue, 25 Aug 2020 09:36:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCB9120706 for ; Tue, 25 Aug 2020 09:36:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FGjZ0di8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="VErwt7Dq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCB9120706 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-Reply-To:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SpvOfW/AJQLWJv1kYsGpDCceSifD/L0RLyb8APmf23g=; b=FGjZ0di86s1ua9QEbqe27F5lR AwBR+zML/TRlzHcuVa8/7f34NPVuxmRZm0orhWmL3rmgBcgZwgs1r5AT/Xc1bnaWahK+1sm3IyyX1 /GKlc/Uusn87wzaSNkeQfctdKPU5pNarQggCgCwFDl4tkZ8kWtGEo0rDJkc95GjmsxZ8xPfqBNvj6 wFQMhdUwx9pvaIo8uZLnJUgS2BMjc0akka8VBXS6wyV6cSu/Ks4sFH6XB5OlUMgMXG7O7GkRp88vl AiC14xAonLovjd6qFsnZmKaKgwHn3P0QpOdBG6p4FEiN/9v5MJ5gtYJ3Qwyxhdl5QkvUu6OnaPS2K PQ4n4s5PQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAVMW-00081g-5S; Tue, 25 Aug 2020 09:35:28 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAVMR-0007zY-SU for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 09:35:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1598348124; x=1629884124; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=imehd6Av3YkuYC+nc5UVG2QVM5uP2/002Rwbm57LAj4=; b=VErwt7DqHmALLYxj0kiCwbC0IhEZbYt0YxBfTrAMpTyt3jI89oGRFrWQ OzFl9Asy/ldBtHUchJanuvhEjIUMaaOmoQDl7xZgl8CHhxNwr1Bb3Irwp 7XsBuFbxyF9b0fPF5E+jwMnD1MNe5TjORGm1GURFBGjnBvqF9Liqu9nAY htpOxlR4V4FhR+adVI1TZXkkJ94f/7xRWonRbrMfV3YBkKSLNYss+cdxH pAZGrwM3Hc1YiBiEmYucLV2uUh14FGWvndH19oM7tM4ktVw52Bj2DYWlk AXzfTFutC/4bAaPtYjvv009//bx0eEytH6+8eXOgX9L7Wan1oYsuT2kcG w==; IronPort-SDR: 6EmdwmgpID8mju0ri4n9FZNsRpGabVlBIRftulRHk0+bN0Q3pcW2ZTdmkcGbEyz9ZHKAevKDM1 HQLmw9DCfYKm8B6KoTGDcnYOMhlh4ZKvoKbmBoEN1STE+lGM8seasctMwl6UbWUHceXp7Lv6uq BWfJmpS8xo9+ZQpO2BM36xw3/Yj1TbKhNtoqdOl0MzS1nAldHV/NH9dLRn9utQTOL6nd8jsvXZ n9UkcaZAG/9t2zVdM00UDmO3cvPmdnJaz97xjeQKi/uGK5rCZ7YSUpOX7BYHxkvahf5IweYcLp CGs= X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="88417367" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 25 Aug 2020 02:35:20 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 25 Aug 2020 02:34:38 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Tue, 25 Aug 2020 02:35:14 -0700 References: <20200824151035.31093-1-lars.povlsen@microchip.com> <20200824151035.31093-2-lars.povlsen@microchip.com> <20200825084752.GD2389103@piout.net> From: Lars Povlsen To: Alexandre Belloni Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: Add Sparx5 SDHCI controller bindings In-Reply-To: <20200825084752.GD2389103@piout.net> Date: Tue, 25 Aug 2020 11:35:14 +0200 Message-ID: <87blizxe3x.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_053524_065831_3D3615E5 X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: DTML , Ulf Hansson , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , Adrian Hunter , Microchip Linux Driver Support , SoC Team , Rob Herring , Linux ARM , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alexandre Belloni writes: > On 25/08/2020 09:33:45+0200, Ulf Hansson wrote: >> On Mon, 24 Aug 2020 at 17:10, Lars Povlsen wrote: >> > >> > The Sparx5 SDHCI controller is based on the Designware controller IP. >> > >> > Signed-off-by: Lars Povlsen >> > --- >> > .../mmc/microchip,dw-sparx5-sdhci.yaml | 65 +++++++++++++++++++ >> > 1 file changed, 65 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml >> > >> > diff --git a/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml b/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml >> > new file mode 100644 >> > index 0000000000000..55883290543b9 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml >> > @@ -0,0 +1,65 @@ >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/mmc/microchip,dw-sparx5-sdhci.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: Microchip Sparx5 Mobile Storage Host Controller Binding >> > + >> > +allOf: >> > + - $ref: "mmc-controller.yaml" >> > + >> > +maintainers: >> > + - Lars Povlsen >> > + >> > +# Everything else is described in the common file >> > +properties: >> > + compatible: >> > + const: microchip,dw-sparx5-sdhci >> > + >> > + reg: >> > + maxItems: 1 >> > + >> > + interrupts: >> > + maxItems: 1 >> > + >> > + clocks: >> > + maxItems: 1 >> > + description: >> > + Handle to "core" clock for the sdhci controller. >> > + >> > + clock-names: >> > + items: >> > + - const: core >> > + >> > + microchip,clock-delay: >> > + description: Delay clock to card to meet setup time requirements. >> > + Each step increase by 1.25ns. >> > + $ref: "/schemas/types.yaml#/definitions/uint32" >> > + minimum: 1 >> > + maximum: 15 >> > + >> > +required: >> > + - compatible >> > + - reg >> > + - interrupts >> > + - clocks >> > + - clock-names >> > + >> > +examples: >> > + - | >> > + #include >> > + #include >> > + sdhci0: mmc@600800000 { >> >> Nitpick: >> >> I think we should use solely "mmc[n]" here. So: >> >> mmc0@600800000 { >> >> Please update patch3/3 accordingly as well. > > This is not what the devicetree specification says. 2.2.2 says that the > generic name is mmc, not mmc[n]. Since there is a proper unit-address, I > don't see the need for an index here. > Alex, Yeah, I thought so as well - and the existing DTs have practically all variations.. Nevertheless, I followed suit since I had to refresh the patch set anyhow. Cheers, ---Lars -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel