From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E0DC433E0 for ; Fri, 3 Jul 2020 10:42:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C48F420723 for ; Fri, 3 Jul 2020 10:42:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3hhUPJOD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="R6OndPXL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C48F420723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RIufwcVOvOyGDP/PC2TDc5f8P7QwPDn+VCmUMm9yDuI=; b=3hhUPJOD4/V+RLe9g+WvSieSl pLZzKexYEpv/jQodakrzstFsfqwzILn6Sa4WBN7Ag7HgDuNEJuxTTgR3t/wb9QZTA+dcWVinM7+SZ ziCgFoy4PUsXyxQHifFok1Y4z5S/c893KMxv697e/ghEaUXe3+qkerE8r92oBSGZyTIuTqFS1sCqb ZL5s0cDT31hu4JS0SHmnZBrrMASHUJ+5Ulktd6uAbSBGSijr3L4j0kFO8xHWG8MbEykFZSbFK6qqc qGHQuu4wzS+XAcJuNXR4hFsoApxJp+aItwYdBHDdzKQz5u/MUnbooKxD1aJMO+TkWnAI+L0s8HIk3 iFdYE59Tg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrJ8M-0007Vh-DE; Fri, 03 Jul 2020 10:41:30 +0000 Received: from ozlabs.org ([2401:3900:2:1::2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrJ8J-0007Tf-61 for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 10:41:28 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49ys2R4MTvz9sQt; Fri, 3 Jul 2020 20:41:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1593772881; bh=ouQdbcbhXEsmtXFYa0vga5m4RkRqU+lSip6svPkAoWE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=R6OndPXLKtiDiQ1Yg6qZjpgHLC6/QS2AlJZYtOzMgFSeYNh6Sx3B0ltJCzh7sjte5 WiiVS0RAL5X390ALRNp7CDkU1RVQeSH9Wca2ibJ08WXyPDBnyYO+Gxoy56H8T0H24A F6WMbq5RKm4waWWNoG6ZJkS8Z04QD4Qfen0kPPO+o9GKjqMlrQM4oL+Hip9uWVFMld UPez+VVedhg6+MIFlsUQ+LqzA6fjTMk4Lbg8v+KsyVDGxyvtiP2F5mRej5ntf0lZ9k 3JqKlIL/mXbyppKeQNjGxRorukCOGXpRzvqKB7CGr+jE5Hsx4Z3fp9XtqzVesL+Bm3 JD0xFqCJG+Szw== From: Michael Ellerman To: Catalin Marinas , Anshuman Khandual Subject: Re: [PATCH V3 (RESEND) 2/3] mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf() In-Reply-To: <20200702140752.GF22241@gaia> References: <1592442930-9380-1-git-send-email-anshuman.khandual@arm.com> <1592442930-9380-3-git-send-email-anshuman.khandual@arm.com> <20200702140752.GF22241@gaia> Date: Fri, 03 Jul 2020 20:43:33 +1000 Message-ID: <87blkw7uay.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_064127_631482_7BA2D683 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Paul Mackerras , Andy Lutomirski , "H. Peter Anvin" , Borislav Petkov , Thomas Gleixner , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Catalin Marinas writes: > On Thu, Jun 18, 2020 at 06:45:29AM +0530, Anshuman Khandual wrote: >> There are many instances where vmemap allocation is often switched between >> regular memory and device memory just based on whether altmap is available >> or not. vmemmap_alloc_block_buf() is used in various platforms to allocate >> vmemmap mappings. Lets also enable it to handle altmap based device memory >> allocation along with existing regular memory allocations. This will help >> in avoiding the altmap based allocation switch in many places. >> >> While here also implement a regular memory allocation fallback mechanism >> when the first preferred device memory allocation fails. This will ensure >> preserving the existing semantics on powerpc platform. To summarize there >> are three different methods to call vmemmap_alloc_block_buf(). >> >> (., NULL, false) /* Allocate from system RAM */ >> (., altmap, false) /* Allocate from altmap without any fallback */ >> (., altmap, true) /* Allocate from altmap with fallback (system RAM) */ > [...] >> diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c >> index bc73abf0bc25..01e25b56eccb 100644 >> --- a/arch/powerpc/mm/init_64.c >> +++ b/arch/powerpc/mm/init_64.c >> @@ -225,12 +225,12 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, >> * fall back to system memory if the altmap allocation fail. >> */ >> if (altmap && !altmap_cross_boundary(altmap, start, page_size)) { >> - p = altmap_alloc_block_buf(page_size, altmap); >> - if (!p) >> - pr_debug("altmap block allocation failed, falling back to system memory"); >> + p = vmemmap_alloc_block_buf(page_size, node, >> + altmap, true); >> + } else { >> + p = vmemmap_alloc_block_buf(page_size, node, >> + NULL, false); >> } >> - if (!p) >> - p = vmemmap_alloc_block_buf(page_size, node); >> if (!p) >> return -ENOMEM; > > Is the fallback argument actually necessary. It may be cleaner to just > leave the code as is with the choice between altmap and NULL. If an arch > needs a fallback (only powerpc), they have the fallback in place > already. I don't see the powerpc code any better after this change. Yeah I agree. cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel