From: Thomas Gleixner <tglx@linutronix.de>
To: Guillaume La Roque <glaroque@baylibre.com>,
vigneshr@ti.com, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tero Kristo <kristo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Guillaume La Roque <glaroque@baylibre.com>
Subject: Re: [PATCH RESEND v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support
Date: Wed, 03 Sep 2025 11:44:40 +0200 [thread overview]
Message-ID: <87cy87zx87.ffs@tglx> (raw)
In-Reply-To: <20250902-timsi-v2-2-a5bf0f32905b@baylibre.com>
On Tue, Sep 02 2025 at 16:43, Guillaume La Roque wrote:
> Add module support to the TI SCI INTA MSI driver:
> - Change Kconfig from bool to tristate to allow module compilation
> - Add linux/module.h include for module functionality
> - Add MODULE_LICENSE, MODULE_DESCRIPTION, and MODULE_AUTHOR macros
>
> This allows the driver to be compiled as a loadable kernel module
> named ti_sci_inta_msi.
No objection per se, but looking at this "driver" just makes me
cry. There is zero justification for this to be separate from the actual
ti-sci-inta irq chip driver, which selects this monstrosity
unconditionally.
All of this code can be moved into the irq chip driver and thereby
consolidated to do the chip initialization and the domain fiddling in
the related data structures instead of doing it programatically.
Consolidating it reduces the number of exports and makes it one module.
No?
Thanks,
tglx
prev parent reply other threads:[~2025-09-03 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:43 [PATCH RESEND v2 0/2] Enable TI SCI INTA MSI as loadable module Guillaume La Roque
2025-09-02 14:43 ` [PATCH RESEND v2 1/2] genirq/msi: Export functions to support TI SCI INTA MSI module Guillaume La Roque
2025-09-04 13:21 ` Dhruva Gole
2025-09-02 14:43 ` [PATCH RESEND v2 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support Guillaume La Roque
2025-09-03 9:44 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy87zx87.ffs@tglx \
--to=tglx@linutronix.de \
--cc=glaroque@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox