From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A331C36002 for ; Fri, 21 Mar 2025 17:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T1YEjPn52FRVRTrD6KDhfuu3b/bEaHroSqlT2w2m7mI=; b=xbM/O54zSSS9W9tqGY2v+4dhBn oc6hrAqQoFF4GTNUMqzI0x0AkKWUjFaNkmg0ecB+64TFxjsnIrcDMBr1UI55KAEpUXXWiEOK0Vs6c x/naoi0FuQO6hD3Fn87OCaWbJQ2PSf+AyWBxSsosHad9JIgX5ZyRUT3hFRd2TVVi/S7NZBjY37xWn CnJlI4FVskKDHFmVVBdXHA71NGlcsrKPOvOh2rOXuJqlF/hPgj6fcN5Vj0LSCwYrS3CjRvyfyPTdr pUJ2rZtOrp+nBM5xsKrXeyNhIUHIoeiIg5m6IgTF2adpbwkW39xwA4kJr5n2QxGjrCEjd+zNZkj+8 cDGQk++w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvfp6-0000000FdPm-3Tuc; Fri, 21 Mar 2025 17:06:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvfnP-0000000Fd1Q-0o6h for linux-arm-kernel@lists.infradead.org; Fri, 21 Mar 2025 17:04:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 773F85C6E5E; Fri, 21 Mar 2025 17:02:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D58BC4CEE3; Fri, 21 Mar 2025 17:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742576674; bh=4BIhvc3+qX0OSvURR+5GbIbaBgN0H4vLEDwiLUkmYk0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r8gXM74F/+FGR0yRaBVaczuaUVE0HAnVuuKBIGwW1wkvw57XgJlAzu5Txf+qOg1yU Pm1KKfAGtuXFjrY2VX+79XtObxfKBwV/wCQDl5/J/oiNix0bXDH6oll9RRVBVYK3zk Wlb6hHOE8FhyDF/V4ggnKrje+iy/YKeb8AVrdDl2JnFBEFIPpYAAWgaRZpHay70pRo u0noL0xozzR6HommJQd7dnQKAQOhT30qDW891zYRxQPM2tZvNAb+mWzqeJvf2mYBn+ wNmpsGilzTsHBW7YEyPi79Z7T/Bjh+n4vYrQEnNDCzZvGvd+4nzwyGipOFSEKg0MDL cutBPKbjuLuIg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tvfnL-00Frrz-HD; Fri, 21 Mar 2025 17:04:31 +0000 Date: Fri, 21 Mar 2025 17:04:22 +0000 Message-ID: <87cyeaqprd.wl-maz@kernel.org> From: Marc Zyngier To: Dan Carpenter Cc: Ricardo Koller , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Shuah Khan , Andrew Jones , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: Fix a couple "prio" signedness bugs In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dan.carpenter@linaro.org, ricarkol@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, pbonzini@redhat.com, shuah@kernel.org, drjones@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250321_100435_312973_1A55FF98 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Dan, On Fri, 21 Mar 2025 14:32:53 +0000, Dan Carpenter wrote: > > There is an assert which relies on "prio" to be signed. > > GUEST_ASSERT(prio >= 0); > > Change the type from uint32_t to int. > > Fixes: 728fcc46d2c2 ("KVM: selftests: aarch64: Add test for restoring active IRQs") > Fixes: 0ad3ff4a6adc ("KVM: selftests: aarch64: Add preemption tests in vgic_irq") > Signed-off-by: Dan Carpenter > --- > --- > tools/testing/selftests/kvm/arm64/vgic_irq.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/arm64/vgic_irq.c b/tools/testing/selftests/kvm/arm64/vgic_irq.c > index f4ac28d53747..e89c0fc5eef3 100644 > --- a/tools/testing/selftests/kvm/arm64/vgic_irq.c > +++ b/tools/testing/selftests/kvm/arm64/vgic_irq.c > @@ -294,7 +294,8 @@ static void guest_restore_active(struct test_args *args, > uint32_t first_intid, uint32_t num, > kvm_inject_cmd cmd) > { > - uint32_t prio, intid, ap1r; > + uint32_t intid, ap1r; > + int prio; > int i; > > /* > @@ -362,7 +363,8 @@ static void test_inject_preemption(struct test_args *args, > uint32_t first_intid, int num, > kvm_inject_cmd cmd) > { > - uint32_t intid, prio, step = KVM_PRIO_STEPS; > + uint32_t intid, step = KVM_PRIO_STEPS; > + int prio; > int i; > > /* Set the priorities of the first (KVM_NUM_PRIOS - 1) IRQs I think this is going in the wrong direction. A GIC priority is an unsigned 8bit value as per the architecture definition. So the type used by the test the first place looks wrong (it is too wide), and the assertion is pointless. Thanks, M. -- Without deviation from the norm, progress is not possible.