From: Thomas Gleixner <tglx@linutronix.de>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com,
shivamurthy.shastri@linutronix.de, anna-maria@linutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] irqchip/irq-mvebu-icu: Fix irq_set_type for sei and nsr
Date: Mon, 20 Jan 2025 09:45:43 +0100 [thread overview]
Message-ID: <87cyghan60.ffs@tglx> (raw)
In-Reply-To: <Z4qbioby2DK2Dddl@eichest-laptop>
On Fri, Jan 17 2025 at 19:03, Stefan Eichenberger wrote:
> It seems that irq_chip_set_type_parent is not failing. By adding some
> debug messages to kernel/irq/manage.c I found that irqd_get_trigger_type
> returns IRQF_TRIGGER_RISING even though it should return
> IRQF_TRIGGER_HIGH according to the device tree. Maybe this was fixed
> between 6.10 and 6.12 but I need to analyze that again in more detail.
The trigger type is fixed up in mvebu_icu_irq_domain_translate(), but
that should be the same with the new code in mvebu_icu_translate().
Can you instrument mvebu_icu_translate() and validate that it is
1) Invoked at all
2) The type fixup is done:
if (msi_data->subset_data->icu_group == ICU_GRP_SEI)
*type = IRQ_TYPE_EDGE_RISING;
Thanks,
tglx
next prev parent reply other threads:[~2025-01-20 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 11:15 [PATCH v1] irqchip/irq-mvebu-icu: Fix irq_set_type for sei and nsr Stefan Eichenberger
2025-01-15 8:15 ` Thomas Gleixner
2025-01-16 17:12 ` Stefan Eichenberger
2025-01-16 21:05 ` Thomas Gleixner
2025-01-17 18:03 ` Stefan Eichenberger
2025-01-20 8:45 ` Thomas Gleixner [this message]
2025-01-20 16:57 ` Stefan Eichenberger
2025-01-23 8:45 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyghan60.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=eichest@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shivamurthy.shastri@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).