From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52C75CE7AB0 for ; Mon, 9 Sep 2024 07:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eDmKeSgpyD+c/apc53M8QdM4nxMlEkeMOklAl7fXPu0=; b=nBvY6cNyzBVuzL8O9pF7MJCCNd 0WoW6qIxphhU1E1PNjhtHDNjRAVZT812jslZXOMEM5YzCyEJRE/gH2dy/Ng0CJidXw+unRGUi1WmS cSMxuDKei1Xrp5gAewaIMXVziyshJVOyhMBWxqndUSoA7Glw2m8HUp3sKiS3K8rKjLB8fgVkkppLo dU+ZYfrbS+U86mhRFqT6f7GmifYqqninGi3oDLmg7C4aJGnUOYDlfLj0dhlOzBkh5DkIlebt6et7c hssQr2M+BhK/hy7I3kHV87MREJStq2EDqVSg8AQokWzex8mHdDZOL21jDDqFiXjE2SMY3ZcHBlKz5 3c3ZHH/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snZ0s-00000000s0F-3het; Mon, 09 Sep 2024 07:40:42 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snYzr-00000000rnL-0Qjj for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2024 07:39:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725867579; x=1757403579; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=RiD2W5cm7ORoR6DJBKgPlV0gjZv3FnjVx+Rnl87vOcQ=; b=d4i6YoexOuyP9rmpjPVxQNh+s5EyPVhLJJqYNuH1bpQppIKM6DxLqyM0 ZBrCggkyCW2zadLIW0Uq5hnye5YUq8AqnubFzlM1F7bB0BDeVT3iTLAmO bIWcQy4OObwuzCRKSENefhuXkKTk/w6pRnCh0Qk6lF74kxEnuJQmMYj7b PWGrxEyGu3CCK5YB0Wf5fif8cOjlL7cncGy9lYo7Iw6YsYa0rHjez/hyy WXaL2YET4KziCf5jdxsP/ELjJl+EsfWMHBQRMg+SpO6r0C9jn+2RIoQP2 7Bqr+f4oC6hohtLYitICffiC2+1KI4ugIulEba3XSyN1TvzYYEqaqeTkR A==; X-CSE-ConnectionGUID: nLa0xpZISy2rOQqHiJ8P5w== X-CSE-MsgGUID: agjmZDJURv+NmQiUTSqvDA== X-IronPort-AV: E=McAfee;i="6700,10204,11189"; a="35135406" X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="35135406" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 00:39:37 -0700 X-CSE-ConnectionGUID: SsRybWOSQ56/LtMdihn0sA== X-CSE-MsgGUID: gd9/a/KITH2+Ip6Ta53C5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="71377491" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.176]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 00:39:32 -0700 From: Jani Nikula To: Christophe JAILLET , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Simona Vetter , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/ipuv3/parallel: Fix an error handling path in imx_pd_probe() In-Reply-To: <1cdd8523443d8850c5531462b30064cb2058924a.1725651992.git.christophe.jaillet@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1cdd8523443d8850c5531462b30064cb2058924a.1725651992.git.christophe.jaillet@wanadoo.fr> Date: Mon, 09 Sep 2024 10:39:28 +0300 Message-ID: <87cyldmg27.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_003939_176824_A9FCA9D0 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 06 Sep 2024, Christophe JAILLET wrote: > If component_add() fails, we need to undo a potential previous > drm_edid_alloc() call. > > Add an error handling path and the missing drm_edid_free(), as already done > in the reomve function. See commit fe30fabf229f ("drm/imx: parallel-display: drop edid override support"). BR, Jani. > > Fixes: 42e08287a318 ("drm/ipuv3/parallel: convert to struct drm_edid") > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/imx/ipuv3/parallel-display.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c > index 91d7808a2d8d..6d51203f7f0f 100644 > --- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c > +++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c > @@ -350,7 +350,15 @@ static int imx_pd_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, imxpd); > > - return component_add(dev, &imx_pd_ops); > + ret = component_add(dev, &imx_pd_ops); > + if (ret) > + goto free_edid; > + > + return 0; > + > +free_edid: > + drm_edid_free(imxpd->drm_edid); > + return ret; > } > > static void imx_pd_remove(struct platform_device *pdev) -- Jani Nikula, Intel