From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CBF7EB64DA for ; Wed, 5 Jul 2023 09:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4+XsNhunSKr95slg7n8YiQT7ISOfN9JNbhUvnKJXADo=; b=VFAn2ClUiHe3rN h/yU6pOILpNPFCNvAEQACDKkSDKU23cluofbkI/0g4sN57HVWyX8rpNvzN5y3cVr0y+1kRafWShGx SvePyxnQCEdVMj44q882k7YNA7+7qratSPvFektsQpgHMC6QbTKzm9E2prarj0EEsCXD75FInSIKb uia13i/GSbQ9hPpyvWpff80DTNs5eE5vaRGzQ5n8WLhbp32dqyAvSPW1xots+nnTj8TBqSy0S0DAb rlnsh/tvj0DlRR6so2/x3hLuq3+3F9eBuMZgce8PaldcM2xidBhSBHKHrDXLbOVaftB1JTKbqZ2Qt k9v0NP3slhKSF3sH3u/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGyaB-00FJvX-0i; Wed, 05 Jul 2023 09:13:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGya9-00FJv2-1F for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 09:13:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688548432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rik35amMtwyfsql6qwDwxhFyML3yiol4Y+GAZ2CyrAI=; b=iNTSzdNa12XsbUMb7g796WRj+R5RHCN6OCFxKCUMoJPTQ/UkjPD/hHYIeOYpPEPSse4rmu /MkenCf0D2sCiTyzblab0HL1bCMfri8CAdjcza/kUsLP+WqWxz0LKZxyc5MrKbCa7+O2c9 lAtCKlQ8GQ8n44s8OmfazPXqlwIMW8Y= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-5QsfVWMsMTKY7nb5_eL7-Q-1; Wed, 05 Jul 2023 05:13:50 -0400 X-MC-Unique: 5QsfVWMsMTKY7nb5_eL7-Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4f76712f950so6043974e87.0 for ; Wed, 05 Jul 2023 02:13:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688548429; x=1691140429; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rik35amMtwyfsql6qwDwxhFyML3yiol4Y+GAZ2CyrAI=; b=Is3x4J77i01OxIxoKGq8WJxIl2Y0zVKpdgeWMUfrrJBNTGqEpD1gw7K5fI2Jf4EG44 /11T+2tFg3YPCFXZsh28DP6RBWqPsR11kG5Ah/5ODg8QWQP6xF9RXGkb/A7dqUd8Yx4R f3AAN8nkcuF4GE9i2eYwJkwdqdRbXmGCvljqGgw0J5wdzgirl8YKKVD1folwtubR4GCw LrYIH+QSKTgktANp+d1ORooC2NgPrEFkKlFN6RYaoqPoL5AV8JnGpZ5Ga2Z1dEeuINLu YaJgEq/Z+xtPPjfwYnO1IR21M7zPKomZ7CWSW2dezHk0wBVDrwEeXHAI1hy4kZUEjRBN Foew== X-Gm-Message-State: ABy/qLYFZ+GwSeXC7FH57PovPouRlF7R0kcBRfdxVUWlElPc95gkIc+0 QvK+ao+pAT4O1gz0r+stCGnMtSUaS9oqC58rZQUhxq5v1lbJSbJ+vJXpnpbb8VCFbtZSq3KWHfQ YysQ83to+758ont9bHrJTJo0c536M4ShmEzU= X-Received: by 2002:a05:6512:2390:b0:4f8:75af:e917 with SMTP id c16-20020a056512239000b004f875afe917mr13371317lfv.41.1688548429591; Wed, 05 Jul 2023 02:13:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlEjlCwK+D/L2otHSAcjbQ8sKKCy18gUu/mb3rWmvZIWyjXZh7PIhlP01348E9bdMzGE5uNgkQ== X-Received: by 2002:a05:6512:2390:b0:4f8:75af:e917 with SMTP id c16-20020a056512239000b004f875afe917mr13371303lfv.41.1688548429289; Wed, 05 Jul 2023 02:13:49 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003fbc2c0addbsm1520495wmc.42.2023.07.05.02.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 02:13:49 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Helge Deller , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/10] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory In-Reply-To: <45ed59d1-32a5-86cb-094f-5ce7ad758d5b@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-2-tzimmermann@suse.de> <875y6ysr6g.fsf@minerva.mail-host-address-is-not-set> <45ed59d1-32a5-86cb-094f-5ce7ad758d5b@suse.de> Date: Wed, 05 Jul 2023 11:13:48 +0200 Message-ID: <87cz16ra9f.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_021353_496559_8F036E31 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: [...] >> >> The comment for I/O memory helpers says: >> >> /* >> * Initializes struct fb_ops for framebuffers in I/O memory. >> */ >> >> I think that would be good to have consistency between these two, > > Sure, I had the same thought. I think I'll rather change the existing > comments a bit. > Yes, that works for me too. Thanks! > Best regards > Thomas > > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel