From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45E19EB64D9 for ; Sat, 17 Jun 2023 16:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=d5BP48PL8YGqHNu0oa3+ykTv/HjClN5iEC/t1GIYASM=; b=UCLPuLEpQ77tyYSUgNf2+Ead1F TnGNDiX31QYqGs01o8/cPQ3/Bh4Dc4Z/CgjHq0StUPibWt9PYr1tbbwSCzfbO70j8L+ewIwCYm/oA bYiCQyhgiqN6vYzUiCq3rmKtH4mfR4xBWNgr3a1gxZ5KdA3fyRVerw884BVxrCDwyXR7367VE95fP h5Gop8JvcwZWwwFSemSZzPTirL/T9kRhqfVp0KCw9yAIufyaTH8SCRbhb1cxGu0/9U3h1BIBcCoO9 VGucP56qLppFZfnY2GDtkMgG7Xel2g92aTYFUfeuuluMAD+M3CWsQYPHr2Dqhu4C7xPQxULt0a3bf QX1bKQlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAZ61-003vnm-0F; Sat, 17 Jun 2023 16:48:17 +0000 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAZ5x-003vmC-10 for linux-arm-kernel@lists.infradead.org; Sat, 17 Jun 2023 16:48:15 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Qk25c6srzz9sNf; Sat, 17 Jun 2023 18:48:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1687020485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oywZapLqwNyrHkbuwEVveNFbHDemaqJwUKPIXYQhvIg=; b=LF3YZg2+edsmb61SmLOGvaNJisClVcQaaOe3GNcmYcrAoTU9J3ldeQNZhINufqXqAx4cRr OEdMmzwMIeYSlvWOelY16SOs8u1IGozEzhemqj5UwrDhU6bQdLbabbvkuO7lOQWYDBErp9 jDjk6esNVRCFUWdnvw/Bf+ODrP6cVjz2jZXTvhNl9bl0/eKRzEl0/2mpSCzD66YJ2kUtdS Z5db+8uyLmoIxLTIc+2409SBd08VvhnO/jlBG0LO7DY7b5TNjr9JTBHar8RFm2HKAe9fJ9 r7bpWcfg/GHx+Qu03kbK8D9sP8c8VNY+twdR0KZLQT5BqRes0T7bjHy3p1a7+g== References: <20230613083626.227476-3-frank@oltmanns.dev> <202306132038.nUB6hmCv-lkp@intel.com> <87edmeqwva.fsf@oltmanns.dev> <875y7ps3tq.fsf@oltmanns.dev> From: Frank Oltmanns To: Stephen Boyd Cc: Michael Turquette , kernel test robot , oe-kbuild-all@lists.linux.dev, "A.s. Dong" , Abel Vesa , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo Subject: Re: [PATCH v2 2/2] clk: tests: Add tests for fractional divisor approximation In-reply-to: Date: Sat, 17 Jun 2023 18:47:54 +0200 Message-ID: <87cz1u2fyd.fsf@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_094813_579616_803256EB X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, On 2023-06-16 at 12:33:51 -0700, Stephen Boyd wrote: > Quoting Frank Oltmanns (2023-06-14 22:16:17) >> Hi Stephen, >> >> On 2023-06-14 at 13:02:24 -0700, Stephen Boyd wrote: >> > Quoting Frank Oltmanns (2023-06-14 01:19:37) >> >> Hi, >> >> >> >> On 2023-06-13 at 20:48:21 +0800, kernel test robot wrote: >> >> Can someone more knowlegdable than me please confirm if my understanding >> >> is correct? >> > >> > Export the symbol. >> >> Ok. I can do that. Please note that I had already submitted a V3 [1], >> that went the way of using clk_fractional_divider_ops.round_rate. I >> apologize for not waiting for your feedback prior to submission. It >> won't happen again. >> >> I liked the approach of calling clk_fd_round_rate directly via the ops, >> because it might allow me to test the other ops as well using the same >> blueprint. Of course, I will not add test cases, if you don't want it. >> (Calling clk_fd_round_rate also had the side effect of teaching me, that >> fd clocks expect the fraction to be less than or equal to 1.) >> >> I don't want to waste your time, but if you could maybe have a chance to >> look at the approach I took in V3 and tell me if you still want me to >> export the symbol instead, that would be really helpful. I'll follow >> your preference. >> >> If I don't hear back until the weekend, I will treat your three words >> above as your preference and prepare a V4 that goes back to calling >> clk_fractional_divider_general_approximation directly. >> > > Just call the API directly. That narrows the test to exactly what we > want to test. If you export the API it will make the rockchip folks > happy too[1]. We of course need to make sure that the registration API > works as well and actually uses the widths that are passed in, but it > doesn't need to fully exercise the approximation algorithm. > > [1] https://lore.kernel.org/r/20230601095512.18029-1-zhangqing@rock-chips.com I've now submitted V5 [1] of this patchset. Unfortunately, V4 [2] had a compiler warning on clang that slipped through the cracks. I'm sorry for the noise. In my opinion V5 is ready for review and hopefully addresses all your previous concerns. Thank you for your patience. Best regards, Frank [1] https://lore.kernel.org/all/20230617131041.18313-1-frank@oltmanns.dev/ [2] https://lore.kernel.org/all/20230617102919.27564-1-frank@oltmanns.dev/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel