From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE95C433EF for ; Wed, 13 Oct 2021 14:53:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82B4561139 for ; Wed, 13 Oct 2021 14:53:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82B4561139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=It8rN0STH5awwwqXqbouluOYQn7SfSWl2jm14QwoMk0=; b=iX1JfsEmblmvOI 9nla3UDowf1UoLYyBSEVRib/xoLKo20MbnCvuvbYs4rylqJW0CAfs8XSdysgY4tRr/39iXRtqfFiD 4F888hxAnRJapXTBdEISKaW2TTBQK6Ag5+N4PdJi0xVrOYNOigGnRnu5snV/zQXFD7HJLuXtkPMrH QRy1Pt9dhWoBBpTlqzzkMpkrEm11RlJ/WL229OA1/FaUnq/qYxt6lAQFIVnGptmOw6LDQSitSRzSh x8qzD+fNrcMbJV6Jh1IL6X4DXh+fLPKO1BNVAgq1hBuZNBpPRlFXnRSv6U45tVralvG+bppMro9Jw xGetPGYfnHMq2PSHjJTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mafcA-00HF8E-MO; Wed, 13 Oct 2021 14:52:18 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mafc6-00HF6t-Il for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 14:52:16 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E7BEA40010; Wed, 13 Oct 2021 14:52:07 +0000 (UTC) From: Gregory CLEMENT To: Chris Packham , andrew@lunn.ch, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, kostap@marvell.com Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham Subject: Re: [PATCH 1/2] arm/arm64: dts: Enable 2.5G Ethernet port on CN9130-CRB In-Reply-To: <20211007230619.957016-2-chris.packham@alliedtelesis.co.nz> References: <20211007230619.957016-1-chris.packham@alliedtelesis.co.nz> <20211007230619.957016-2-chris.packham@alliedtelesis.co.nz> Date: Wed, 13 Oct 2021 16:52:02 +0200 Message-ID: <87czo9dlkd.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_075214_777870_B07A4BF9 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Chris, > Enable the 2.5G Ethernet port by setting the status to "okay" and the > phy-mode to "2500base-x" on the cn9130-crb boards. Tested on a > CN9130-CRB-A. > > Signed-off-by: Chris Packham As I am not sure that next week the pull request will be accepted when you will send the v2 for the second patch, I already applied the one on mvebu/dt64 Thanks, Gregory > --- > > The Marvell SDK adds 2500base-t and uses it in the equivalent dtsi but > looking at the documentation for both the SoC and the PHY I think > 2500base-x is correct for the system interface (the line side is > 2500base-t). > > arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi > index 505ae69289f6..e7918f325646 100644 > --- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi > +++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi > @@ -214,8 +214,8 @@ &cp0_eth1 { > }; > > &cp0_eth2 { > - /* This port uses "2500base-t" phy-mode */ > - status = "disabled"; > + status = "okay"; > + phy-mode = "2500base-x"; > phy = <&nbaset_phy0>; > phys = <&cp0_comphy5 2>; > }; > -- > 2.33.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel