From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08FACA9EC0 for ; Mon, 28 Oct 2019 21:57:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65DCA21479 for ; Mon, 28 Oct 2019 21:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cieJP6rS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65DCA21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O0yE2iDGh55zWA6aYlxkbm7RltIsTmVojXBMxpwH/bY=; b=cieJP6rSKYJVzR GJwelQiokwQBu/eVQOME1O+wGD5UtaJC1VKj8Kw3rowPl5Mp/IFH8e33DpNaoYVJBjkdH37E2iP76 dxiVtx1e3jH0IAY5VzjgofT2m5sKxFYP6DRxxbRgE1YfTG7HXOGSDL7FieHnDut0EftCOKzSEvuW9 QIOi860JA4/0amlieclBAy/fP4U3Pkk2hBj4Dl4C1q9mQycpqFx79e2bdhlZuRLGyPosr5BRnK+FU M5CyI0p0CaxVANIkrPslNrfCxUBkPP4aQsyZzmmFcwg4yaJvvx0XacEEiHehtFCDTCTGX3gM1qSOv OrbrmrtSU3C/LXLD+WOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPD1J-0003zi-Ou; Mon, 28 Oct 2019 21:57:49 +0000 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPD1F-0003yn-Pg for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 21:57:47 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9xj210025TFNlm039xje7; Mon, 28 Oct 2019 22:57:43 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:57:43 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH 33/46] ARM: pxa: pcmcia: move smemc configuration back to arch References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-33-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:57:43 +0100 In-Reply-To: <20191018154201.1276638-33-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:48 +0200") Message-ID: <87d0egjzxk.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_145746_110415_6D4B6558 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-kernel@vger.kernel.org, Dominik Brodowski , Haojian Zhuang , Daniel Mack , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > Rather than poking at the smemc registers directly from the > pcmcia/pxa2xx_base driver, move those bits into machine file > to have a cleaner interface. > > Cc: Dominik Brodowski > Signed-off-by: Arnd Bergmann > -static int pxa2xx_pcmcia_set_mcxx(struct soc_pcmcia_socket *skt, unsigned int clk) > +static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt) > { > + unsigned long clk = clk_get_rate(skt->clk) / 1000; > struct soc_pcmcia_timing timing; > int sock = skt->nr; > > soc_common_pcmcia_get_timing(skt, &timing); > > - pxa2xx_pcmcia_set_mcmem(sock, timing.mem, clk); > - pxa2xx_pcmcia_set_mcatt(sock, timing.attr, clk); > - pxa2xx_pcmcia_set_mcio(sock, timing.io, clk); > + pxa_smemc_set_pcmcia_timing(sock, > + pxa2xx_pcmcia_mcmem(sock, timing.mem, clk), > + pxa2xx_pcmcia_mcatt(sock, timing.attr, clk), > + pxa2xx_pcmcia_mcio(sock, timing.io, clk)); > > return 0; > } > > -static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt) > -{ > - unsigned long clk = clk_get_rate(skt->clk); > - return pxa2xx_pcmcia_set_mcxx(skt, clk / 10000); That curious, because you divide here by 10^4, while in the old pxa2xx_pcmcia_set_mcxx() that was 10^3 ... is that a fix I don't see ? Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel