From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D8CC4360F for ; Fri, 15 Mar 2019 13:43:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EBF621019 for ; Fri, 15 Mar 2019 13:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MZCtwScK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EBF621019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Grqv4P9BIOgKFH9GRTnntRifqeEwdkwfj5AwmjMIAs=; b=MZCtwScK7MyJgy ueVE9eLpwCt7cXXTUiTgTO66yB69Om3kZBf27pa1d2v0Dnm3h0lV5tjt6Ht/ZP5b+yHi4k9qmMxJU 5sIiKWYreUCEnuhTfaTyTyYaoQ2G+TEDlIR20CjMYr0wM8jjs4OR/xxRrImI2oZalKkRZxSlOvrYf tFjMtJTUaAkiN58KT/Gcolb0580zqVEBl3yp2LbhAb/jycL8TLU7HgvBKteo7pymfisuoI6D202oW kRbJxay+6gLPdVO+wN9ezFCsKUgAcfc7Cb1r8iGtJ9t/x6PcPcCitNdrdOgnxqObdebePFdxPBmYr eD/IW96KmpKcDyNAQijA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4n7R-0007XV-8q; Fri, 15 Mar 2019 13:43:29 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4n6r-0006cK-Ss for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 13:42:56 +0000 X-Originating-IP: 109.213.80.250 Received: from localhost (alyon-652-1-57-250.w109-213.abo.wanadoo.fr [109.213.80.250]) (Authenticated sender: gregory.clement@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C9E5A4000F; Fri, 15 Mar 2019 13:42:51 +0000 (UTC) From: Gregory CLEMENT To: Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH 2/3] rtc: mv: convert to devm_rtc_allocate_device In-Reply-To: <20190315133513.9909-2-alexandre.belloni@bootlin.com> References: <20190315133513.9909-1-alexandre.belloni@bootlin.com> <20190315133513.9909-2-alexandre.belloni@bootlin.com> Date: Fri, 15 Mar 2019 14:42:51 +0100 Message-ID: <87d0mstfs4.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_064254_078186_5D0F4330 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexandre, On ven., mars 15 2019, Alexandre Belloni wrote: > This allows further improvement of the driver. > > Signed-off-by: Alexandre Belloni Tested-by: Gregory CLEMENT on Armada XP GP Thanks, Gregory > --- > drivers/rtc/rtc-mv.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c > index d13d06ea6709..ef704aef8663 100644 > --- a/drivers/rtc/rtc-mv.c > +++ b/drivers/rtc/rtc-mv.c > @@ -254,15 +254,7 @@ static int __init mv_rtc_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pdata); > > - if (pdata->irq >= 0) { > - device_init_wakeup(&pdev->dev, 1); > - pdata->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, > - &mv_rtc_alarm_ops, > - THIS_MODULE); > - } else { > - pdata->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, > - &mv_rtc_ops, THIS_MODULE); > - } > + pdata->rtc = devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(pdata->rtc)) { > ret = PTR_ERR(pdata->rtc); > goto out; > @@ -278,7 +270,16 @@ static int __init mv_rtc_probe(struct platform_device *pdev) > } > } > > - return 0; > + if (pdata->irq >= 0) { > + device_init_wakeup(&pdev->dev, 1); > + pdata->rtc->ops = &mv_rtc_alarm_ops; > + } else { > + pdata->rtc->ops = &mv_rtc_ops; > + } > + > + ret = rtc_register_device(pdata->rtc); > + if (!ret) > + return 0; > out: > if (!IS_ERR(pdata->clk)) > clk_disable_unprepare(pdata->clk); > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel