From mboxrd@z Thu Jan  1 00:00:00 1970
From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: Fri, 21 Sep 2018 22:34:03 +0200
Subject: [PATCH 3/5] spi: pxa2xx: use an enum for type
In-Reply-To: <20180910115935.163121-4-lkundrak@v3.sk> (Lubomir Rintel's
 message of "Mon, 10 Sep 2018 13:59:33 +0200")
References: <20180910115935.163121-1-lkundrak@v3.sk>
 <20180910115935.163121-4-lkundrak@v3.sk>
Message-ID: <87d0t64mkk.fsf@belgarion.home>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Lubomir Rintel <lkundrak@v3.sk> writes:

> That seems to be the correct type.
Okay, but what happens here when adev_id->driver_data is a value out of enum
range ? Does the following assignment make sense ?
> +		type = (enum pxa_ssp_type)adev_id->driver_data;

As a side note, could you join for the next throw to the review :
 - Jarkko Nikula <jarkko.nikula@linux.intel.com>
 - Mika Westerberg <mika.westerberg@linux.intel.com>

Even if they are Intel, I think they have worked a lot on this driver for Intel
platforms.

Cheers.

-- 
Robert