From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 475D3D0EE18 for ; Tue, 25 Nov 2025 19:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s62bY15dl8LjlASAY70O8ixMsJqDzCBLVzHKsTGOxbw=; b=d86j/n1bblTzSg7MKVXc+CNAsG sa5fywJ0tRyNU2IsHXGU7Yv6NpjGSgVKy4kiCCDKE8hh6JpoKIt0muUgbxjm9yM/6xZBFTQq5v9zJ GAGRBcKAX4cwJfn14gDQHpAlQ66uZyay43KnryazBVy7fjsCaP6bfF6fLsWmWf1jaaFzpCE7OFlh8 6+1lSfaUtt5Gof/re+2UpU+eZpmJOTNwBjPofLBkUnZ5m/QrqsuPs3UEAt8klx9Q8iyOhc1WFUGyO Kk9hjOAzL9A9zJLt784k2Hd2gTYfAnwzgi98BBqE2KiUsiAugT9TZxXRd70WpsFwW0ZQG1Xw9ZVw1 jnwox20g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyw8-0000000DqtG-3eyw; Tue, 25 Nov 2025 19:42:52 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyw7-0000000Dqsr-0cVp for linux-arm-kernel@lists.infradead.org; Tue, 25 Nov 2025 19:42:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CA5A7405AF; Tue, 25 Nov 2025 19:42:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A79ADC4CEF1; Tue, 25 Nov 2025 19:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764099770; bh=EH5HQVZ4pVflbpU68pvKHubZ0K2IYSrdTVT51BYzWEo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DsUY5hRYzfqkGz84KqeI8ykvjkXvHFogdOuTZISZ1HlQ3iWfar5088nRWuAbxCBZC ukjMV4DN9o4vTQ/aC6z63GOvNjJj3Yn+theY4+NI6hgat6JiFDYUq8GTVmZi8Av+ZU ODPDmyRqsSdNTIos2LyZKTNgplyfFYC6WeR5XJrTMPkHBun+WJf0IfHCAhmg8RDhTK bHX7HlbORW6yiJ0i2SI159BRkioCcSgt+UUuuL+UZzpYMwJuf5ggXt9IucyJhTa76y bckSyrokrdh5xBjk3r6PSizr7rk5mHZoZjc+QCYU3Bk8auyr+rurVx6r7WhoQP8IYi AEm8L4vFk38NA== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vNyw4-00000008GHt-235b; Tue, 25 Nov 2025 19:42:48 +0000 Date: Tue, 25 Nov 2025 19:42:48 +0000 Message-ID: <87ecplgapz.wl-maz@kernel.org> From: Marc Zyngier To: Nathan Chancellor Cc: Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH] KVM: arm64: Add break to default case in kvm_pgtable_stage2_pte_prot() In-Reply-To: <20251125-arm64-kvm-hyp-pgtable-fix-c23-ext-warn-v1-1-98b506ddefbf@kernel.org> References: <20251125-arm64-kvm-hyp-pgtable-fix-c23-ext-warn-v1-1-98b506ddefbf@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: nathan@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, llvm@lists.linux.dev, patches@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_114251_204261_D601FA84 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 Nov 2025 17:59:15 +0000, Nathan Chancellor wrote: > > Clang warns (or errors with CONFIG_WERROR=y / W=e): > > arch/arm64/kvm/hyp/pgtable.c:757:2: error: label at end of compound statement is a C23 extension [-Werror,-Wc23-extensions] > 757 | } > | ^ > > With older versions of clang (15 and older) and GCC (at least the minimum > supported, 8.1), this is an unconditional hard error: > > arch/arm64/kvm/hyp/pgtable.c: In function 'kvm_pgtable_stage2_pte_prot': > arch/arm64/kvm/hyp/pgtable.c:756:2: error: label at end of compound statement > default: > ^~~~~~~ > > arch/arm64/kvm/hyp/pgtable.c:756:10: error: label at end of compound statement: expected statement > default: > ^ > ; > > Add a break statement to this default case to clear up the error/warning. > > Fixes: 2608563b466b ("KVM: arm64: Add support for FEAT_XNX stage-2 permissions") > Signed-off-by: Nathan Chancellor Acked-by: Marc Zyngier M. -- Jazz isn't dead. It just smells funny.