From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFD9DCA0EFF for ; Thu, 21 Aug 2025 19:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xSwFib4+R+MbdTZX8/a+Pauk5UKs0Fqxl9UQGRwnJuY=; b=1NBLtW22hqrYuEpEnI0w/rlH99 QrUaOnm1NQzmciU9KbGMJQm63aHtk0fJdRpCDJ/jZ+lNEaIYBQrDrMr3RxQO42RL8GqzedV0OxIdh xe3BDn5oqaLDBVslWq4jHabRK+7HF5RoXgb4N6SaAmMRcxes1sw1p1AoJqFZgM+4RmlsLag3V6qwm POQ6+QWsThpXDa5Lkjb3urPHa5P8X4Ldu4z+suZkMKubn0VXIUsC7Bqv/nRGmCwKEnZiLLiq7nyAE 1fsL1epEBKq/k6LaahwbIZ6VKd22NpmjBH3AJJH6HFkExFYvUsankvXxzlzMbwNSobhtaaCEtjsAy qsYXN3pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upAhi-00000000EJ2-1Qi4; Thu, 21 Aug 2025 19:12:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1up5UH-0000000H55G-2EJh for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2025 13:37:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B880A5C6BE1; Thu, 21 Aug 2025 13:37:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 602E9C4CEEB; Thu, 21 Aug 2025 13:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755783472; bh=UMit3pM8AU7+lQGrXW7ldyumPdBiexZYtfFhkQTv3tg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fq4omt74VbPOz2zLJNKG3JLPia0/0xlda+LJ/ivSZb7JqgqU1VBcYxoRkSofTYE1C VNhZuANmiIg9yldegF7paIYorS2V/KnU9/8QG2dlsNLNGiyzG3oqM2jaL9YuAei0DK cCQRu4RhvyjklZjLhsQyvlaRa41R4UZU7p2QuRcvqaJ429KcPhJmQUhQigUqfUhFj9 bk9mi+Mscvgvcuqye3jx7mpnIbIRzvBfNWxw1P8hzwABZkqTN0PHgkwIhfwN74BSKD Wik2KYo9/SNA+vezgqfGzyjil6NltGq67P9dz5nsq+r4YsH0/8JEdfcp0uZG/fnHrG a6ywANDhKT6mw== Received: from host86-149-246-145.range86-149.btcentralplus.com ([86.149.246.145] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1up5UA-009kxL-Sm; Thu, 21 Aug 2025 14:37:47 +0100 Date: Thu, 21 Aug 2025 14:37:45 +0100 Message-ID: <87ect4kd7a.wl-maz@kernel.org> From: Marc Zyngier To: Ben Horgan Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Will Deacon , Catalin Marinas , Cornelia Huck Subject: Re: [PATCH v3 2/6] KVM: arm64: Handle RASv1p1 registers In-Reply-To: <95819606-ef3b-46e1-8201-1abf0219659f@arm.com> References: <20250817202158.395078-1-maz@kernel.org> <20250817202158.395078-3-maz@kernel.org> <95819606-ef3b-46e1-8201-1abf0219659f@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 86.149.246.145 X-SA-Exim-Rcpt-To: ben.horgan@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, will@kernel.org, catalin.marinas@arm.com, cohuck@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_063753_656939_9314A2E7 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Aug 2025 14:13:52 +0100, Ben Horgan wrote: > > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > > index 82ffb3b3b3cf7..feb1a7a708e25 100644 > > --- a/arch/arm64/kvm/sys_regs.c > > +++ b/arch/arm64/kvm/sys_regs.c > > @@ -2697,6 +2697,18 @@ static bool access_ras(struct kvm_vcpu *vcpu, > > struct kvm *kvm = vcpu->kvm; > > switch(reg_to_encoding(r)) { > > + case SYS_ERXPFGCDN_EL1: > > + case SYS_ERXPFGCTL_EL1: > > + case SYS_ERXPFGF_EL1: > > + case SYS_ERXMISC2_EL1: > > + case SYS_ERXMISC3_EL1: > > + if (!(kvm_has_feat(kvm, ID_AA64PFR0_EL1, RAS, V1P1) || > > + (kvm_has_feat_enum(kvm, ID_AA64PFR0_EL1, RAS, IMP) && > > + kvm_has_feat(kvm, ID_AA64PFR1_EL1, RAS_frac, RASv1p1)))) { > > + kvm_inject_undefined(vcpu); > > + return false; > > + } > > + break; > > default: > > if (!kvm_has_feat(kvm, ID_AA64PFR0_EL1, RAS, IMP)) { > > kvm_inject_undefined(vcpu); > The default condition needs updating for the case when > ID_AA64PFR0_EL1.RAS = b10 otherwise access to the non-v1 specific RAS > registers will result in an UNDEF being injected. I don't think so. The RAS field is described as such: UnsignedEnum 31:28 RAS 0b0000 NI 0b0001 IMP 0b0010 V1P1 0b0011 V2 EndEnum Since this is an unsigned enum, this checks for a value < IMP. Only RAS not being implemented is this condition satisfied, and an UNDEF injected. Or am I missing something obvious here (I wouldn't be surprised...)? M. -- Jazz isn't dead. It just smells funny.