From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBA24C67861 for ; Sat, 6 Apr 2024 09:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jHHfPN/2h/vEw8Vcv3EB7c+ZsuF8kecAyiQ9WhS5TPE=; b=eaVXi9kJT+g5KV Qy4s3SFtS28WyzA2I7yU1+0y4d7ljBc3Lh3ntp7kk8gx1/6qHDWs25a1rKkzKpwk9LF5v2M2MK/YG EfHc2b6HsFrjsSRby4rjjKYp1mGckL5O9YN33dXT0nzSvIDYM4rENmM77ebH4OifoZrwDklBU0Xry IU0Wgzc2ioMYtDlncG6GtDL31pFNLeRHZzAFGAHqKiE95A78HAz3d4sMJPQKk+PZbbgj4fwBFa2ey dzpcs+w/3Zm4BZjwNZ/8AkWBEJjyzRxl1n63JvsbgoGbZMjP95qPKN2dgKslPGjMct04xmHyr6au1 61f9o3sdjzAAxe8L2S+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt2oT-0000000A5X8-16hy; Sat, 06 Apr 2024 09:58:17 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt2oQ-0000000A5Wd-2xn1 for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 09:58:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 38B1B6097A; Sat, 6 Apr 2024 09:58:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5980C433F1; Sat, 6 Apr 2024 09:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712397492; bh=8QOjyi5yo48Gc03G0D16O76wbrg04l+eAGY55tGyRSA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WCkKDUoAxS1hNUGaSvzPdz2OgUBAYcdgTIVhIbTpjTlKHpT4oiiTjTA0d/5hEjbIw SaDvW5m9P3E795ro7EQFODrYT5fjjj17ebXlda5cKDnqo+aWnKqFOz3HOUNfGlRXeO OPE46yAkQNN4By0DGlYpNVWjOAVaY9M6HOnVSSlQX4UFS82YQyVmX6jGgeeIvMNWTq hYBzpb2HrXqx9yZTmtrr0Xt/VldxNWneHQ6NGQOErVp99A7yR2HbvvUBwnxWXWruV2 5qErzfhTtLOjB4O0+3l4jqYe2nmFvSHN/J/uh+H6KVAedg1/uPzarykMkR8QkCdPrc +J38PgGCQEmmg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rt2oM-0023Jb-Jp; Sat, 06 Apr 2024 10:58:10 +0100 Date: Sat, 06 Apr 2024 10:58:10 +0100 Message-ID: <87edbisthp.wl-maz@kernel.org> From: Marc Zyngier To: Nianyao Tang , Thomas Gleixner Cc: , , , , Subject: Re: [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped VPE In-Reply-To: <20240406022737.3898763-1-tangnianyao@huawei.com> References: <20240406022737.3898763-1-tangnianyao@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tangnianyao@huawei.com, tglx@linutronix.de, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, guoyang2@huawei.com, wangwudi@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_025814_810245_428536C5 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 06 Apr 2024 03:27:37 +0100, Nianyao Tang wrote: > > As per the GICv4.1 spec (Arm IHI 0069H, 5.3.19): > > "A VMAPP with {V, Alloc}=={0, x} is self-synchronizing, This means the > ITS command queue does not show the command as consumed until all of > its effects are completed." > > Furthermore, VSYNC is allowed to deliver an SError when referencing a > non existent VPE. > > By these definitions, a VMAPP followed by a VSYNC is a bug, as the > later references a VPE that has been unmapped by the former. > > Fix it by eliding the VSYNC in this scenario. > > Fixes: 64edfaa9a234 ("irqchip/gic-v4.1: Implement the v4.1 flavour of VMAPP") > > Signed-off-by: Nianyao Tang > Reviewed-by: Marc Zyngier Thanks for having taken my remarks into account, it looks good now. Thomas, can you please take this as a fix for 6.9? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel