From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14172C54E4A for ; Fri, 8 Mar 2024 07:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O3pW+a/KM3ozxw+zeYg8b78fnH/P1+HpUxY1IKi7cCo=; b=wBh8XVoCx1I3oz rVdAfYLb4Zauy46z5gK8/z2kvGy0O1Twd10bvN9V7e1k+CfulMkNFRPXvG6eRQeYxXKEBlWpjlYMD elK1yni0bEnsS2y6LRKPI2q1Lyj47qfD0PLMMFFWifyPfY3i2yJiONTklt/fl69RiuexiQyexNCrs qO11q1/7EGygfzOjXkxX7br1Er2n+Kt5FwQvBafPAoQFg+CWdLSQgthLr0KF26yxLxgyfd/s6H+2U VzlyVzr5HcvKwgv6GFK4LWla/UjIEVjekWICWZ621AsvIK9kGY6IZ0ZW4KwQoflF+8OSDsFbZOdze +oxtCZAOZJl/J2PG5JYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUmf-00000008AJ2-3261; Fri, 08 Mar 2024 07:36:49 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riUmc-00000008AIB-13sF for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 07:36:48 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 07F1920007; Fri, 8 Mar 2024 07:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709883401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGSqe7AdSDq/rJELatqXvjh2l9o5p+96qyY9cUtuWlw=; b=DqWmuoxK2s2FgZggo+7Fb+2aCTBDGG26G0JrfQh4B+IpyGom4N8b/iHlAFgV0XvbuXPgS2 A/nThYrBp2kX2h3tcTQ3iBXWi1EjXh3f/Quu9oKQGC2EXlptBTaZo3Sg/hPzzxA+K7EH48 ZwOgvj/m9z87BaLl2ySAxP45teiKUEbKgBGnojsdEKJw7wofXlUaUbyuNx2Tknv97J02uC XLa421ACTtXtvuCAL9Fa7kuzijn6vGxHhXb9innAJFDOYeyVz8N7V/a79gK7MTgfaq3kKQ p1Z11i73iycAH4WmBFFUhhspQSAfmAW6ryMHpC1F5b+64G3CKFdzJTxSpP5CUA== From: Gregory CLEMENT To: Chris Packham , andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, lee@kernel.org Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: Re: [PATCH v5 3/3] ARM: dts: marvell: Add 7-segment LED display on x530 In-Reply-To: <20240306235021.976083-4-chris.packham@alliedtelesis.co.nz> References: <20240306235021.976083-1-chris.packham@alliedtelesis.co.nz> <20240306235021.976083-4-chris.packham@alliedtelesis.co.nz> Date: Fri, 08 Mar 2024 08:36:40 +0100 Message-ID: <87edclgoon.fsf@BL-laptop> MIME-Version: 1.0 X-GND-Sasl: gregory.clement@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_233646_462537_A698D7A0 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Chris Packham writes: > The Allied Telesis x530 products have a 7-segment LED display which is > used for node identification when the devices are stacked. Represent > this as a gpio-7-segment device. > > Signed-off-by: Chris Packham Acked-by: Gregory CLEMENT Normally, this patch should be taken in mvebu and then merged by arm-soc. However, I haven't seen any other patch touching this file (so no risk of merge conflict) and I think it's too late for me to make a new pull request to arm-soc. So I'm not against it being taken with the rest of the patches. However, I think it would be a good idea to see what Arnd thinks about it. Gregory > --- > > Notes: > Changes in v5: > - group GPIO specifiers > Changes in v4: > - Use correct compatible name in commit message > Changes in v3: > - Use compatible = "gpio-7-segment" as suggested by Rob > Changes in v2: > - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy > > arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts > index 5a9ab8410b7b..2fb7304039be 100644 > --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts > +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts > @@ -43,6 +43,17 @@ uart0: serial@12000 { > }; > }; > }; > + > + led-7seg { > + compatible = "gpio-7-segment"; > + segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 1 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 2 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 3 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 4 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 5 GPIO_ACTIVE_LOW>, > + <&led_7seg_gpio 6 GPIO_ACTIVE_LOW>; > + }; > }; > > &pciec { > @@ -149,7 +160,7 @@ i2c@3 { > #size-cells = <0>; > reg = <3>; > > - gpio@20 { > + led_7seg_gpio: gpio@20 { > compatible = "nxp,pca9554"; > gpio-controller; > #gpio-cells = <2>; > -- > 2.43.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel