From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59D3BC433F5 for ; Tue, 4 Oct 2022 01:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GU935zQTMAvB++880sNaNa3aqG9jhj03vts6Ptu3YF8=; b=MAGQnb/di+jSXz cvWa/buoWJwZhyF2qTdj0pweyijAeRQ/XAcRYiNB7aqPj/OereWnELwg7WqMv4lZpQbab8UVyDNQQ 5YeUIJ5A41IEWsLlF7Ko6rO2NTlG9GRNjLffwHqS0V8+49L/I0y6XDCypplwEUzEGYUP6lIafgXwX kbPzZSrcfCTlNvIt5QW9Y0zv4yv97iLdBkHSeQe4hzlaynq61LC0qI95dAXzrEAF4j/P5Yqth1QWq mHrJtP/TljUMPtwn2rmDp9sYxFryeFWmvuznKzCp9ZCPFiGJpZapzVGs6/S87NcNMEVUOEZUAeeTp FtE7Al7SiGorHLlTXySw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofWiy-008Evp-03; Tue, 04 Oct 2022 01:27:56 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofWiu-008Eub-68 for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 01:27:54 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4MhKnj3qpkz4xDn; Tue, 4 Oct 2022 12:27:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1664846861; bh=dILIPkBSNiaMmuEgx2aZ/VK27RtnOYvEUacjVkijs74=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HPNFOfyi/pQutZwIwhl9fl4tsacR4hDZWC2YrVMONUfvmLO5pv/mIQSiaiDj293Vj qDjrx+kFb5O4BRjKAFQiSUMoyki5soVCJW3RFUXOZWq8QZOFcauFpzaROuZUUCaZVT RVxUOUcQuAyLEkSxNn60QjHxtWQuloChpMU+NUW0NgdV/QTXGvCtCfGNZAmBISvy5Y M5Z9rpFqf6Pw9qDYvHYO2RFzBrFebkxJ7ZDEND8o9rLMks35MtA5ofZhL5KzRCnts5 mNZkDft0YVolHC1fX63JO3m1TWrQBor9b7Or9tYTRngCbk7AgDMptELDvaOoQi1/+e jcCmCeuZdkc4Q== From: Michael Ellerman To: Sven Peter , Arminder Singh , Wolfram Sang Cc: Alyssa Rosenzweig , asahi@lists.linux.dev, Benjamin Herrenschmidt , Christian Zigotzky , Darren Stevens , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev , Hector Martin , Paul Mackerras Subject: Re: [PATCH v2] i2c-pasemi: PASemi I2C controller IRQ enablement In-Reply-To: <5e89999e-5c9d-428c-a6c6-b454fb47aaa3@app.fastmail.com> References: <5e89999e-5c9d-428c-a6c6-b454fb47aaa3@app.fastmail.com> Date: Tue, 04 Oct 2022 12:27:36 +1100 Message-ID: <87edvoped3.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_182752_603525_BDC82029 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Sven Peter" writes: > On Sun, Oct 2, 2022, at 16:07, Arminder Singh wrote: >> Hi, >> >>> #define REG_MTXFIFO 0x00 >>> #define REG_MRXFIFO 0x04 >>> #define REG_SMSTA 0x14 >>> +#define REG_IMASK 0x18 >> >>> This doesn't seem to be aligned correctly, this file seems to use a tab >>> to separate the register name and the offset and you used spaces here. >> >>> @@ -15,7 +16,11 @@ struct pasemi_smbus { >>> struct i2c_adapter adapter; >>> void __iomem *ioaddr; >>> unsigned int clk_div; >>> - int hw_rev; >>> + int hw_rev; >>> + int use_irq; >>> + struct completion irq_completion; >> >>> This doesn't seem to be aligned correctly and the hw_rev line >>> doesn't have to be changed. >> >> I'm sorry for the alignment issues in the patch, I genuinely didn't notice >> them as from the perspective of my primary editor (Visual Studio Code) >> the entries were aligned. I just saw them when opening the files in >> nano. > > No worries, it's just a small nit and quickly fixed after all! :) > >> >> Does fixing the alignment issues and the commit description justify a v3 >> of the patch or should the minor fixes go out as a "resend"? Just not sure >> in this particular case as the fixes seem to be very minor ones. > > I'd send a v3. I've only used resend when e.g. my previous mail provider > messed up and silently converted all my outgoing mails to HTML. If you've modified the patches then it's not a "resend": https://www.kernel.org/doc/html/latest/process/submitting-patches.html#don-t-get-discouraged-or-impatient So yeah send a v3 in this case. cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel