From: Marc Zyngier <maz@kernel.org>
To: Fuad Tabba <tabba@google.com>
Cc: kvmarm@lists.cs.columbia.edu, will@kernel.org,
qperret@google.com, james.morse@arm.com,
alexandru.elisei@arm.com, suzuki.poulose@arm.com,
catalin.marinas@arm.com, drjones@redhat.com,
linux-arm-kernel@lists.infradead.org, kernel-team@android.com
Subject: Re: [PATCH v2 3/4] KVM: arm64: Pass pmu events to hyp via vcpu
Date: Mon, 09 May 2022 11:41:22 +0100 [thread overview]
Message-ID: <87ee136l9p.wl-maz@kernel.org> (raw)
In-Reply-To: <20220509095500.2408785-4-tabba@google.com>
On Mon, 09 May 2022 10:54:59 +0100,
Fuad Tabba <tabba@google.com> wrote:
>
> Instead of the host accessing hyp data directly, pass the pmu
> events of the current cpu to hyp via the vcpu.
>
> This adds 64 bits (in two fields) to the vcpu that need to be
> synced before every vcpu run in nvhe and protected modes.
> However, it isolates the hypervisor from the host, which allows
> us to use pmu in protected mode in a subsequent patch.
>
> No functional change intended.
BTW, there *are* plenty of functional changes, even if there was no
issue with the patch. The lifetime of the data structure changes, its
sharing changes, and its memory footprint is different.
I guess what you are trying to say is that there shouldn't be any
visible side effect of this patch. But I don't think these are the
same things.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-09 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 9:54 [PATCH v2 0/4] KVM: arm64: Do not communicate host pmu event changes by accessing hyp data Fuad Tabba
2022-05-09 9:54 ` [PATCH v2 1/4] KVM: arm64: Wrapper for getting pmu_events Fuad Tabba
2022-05-09 9:54 ` [PATCH v2 2/4] KVM: arm64: Repack struct kvm_pmu to reduce size Fuad Tabba
2022-05-09 9:54 ` [PATCH v2 3/4] KVM: arm64: Pass pmu events to hyp via vcpu Fuad Tabba
2022-05-09 10:31 ` Marc Zyngier
2022-05-09 10:47 ` Fuad Tabba
2022-05-09 10:41 ` Marc Zyngier [this message]
2022-05-09 10:48 ` Fuad Tabba
2022-05-09 9:55 ` [PATCH v2 4/4] KVM: arm64: Reenable pmu in Protected Mode Fuad Tabba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee136l9p.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=qperret@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).