From: Marc Zyngier <maz@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, james.morse@arm.com,
suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu,
mark.rutland@arm.com
Subject: Re: [PATCH v2 5/5] KVM: arm64: uapi: Add kvm_debug_exit_arch.hsr_high
Date: Thu, 21 Apr 2022 13:58:52 +0100 [thread overview]
Message-ID: <87ee1qa8z7.wl-maz@kernel.org> (raw)
In-Reply-To: <20220421100547.873761-6-alexandru.elisei@arm.com>
On Thu, 21 Apr 2022 11:05:47 +0100,
Alexandru Elisei <alexandru.elisei@arm.com> wrote:
>
> diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
> index 93d92130d36c..fd5b6773e3a2 100644
> --- a/arch/arm64/kvm/handle_exit.c
> +++ b/arch/arm64/kvm/handle_exit.c
> @@ -121,6 +121,8 @@ static int kvm_handle_guest_debug(struct kvm_vcpu *vcpu)
>
> run->exit_reason = KVM_EXIT_DEBUG;
> run->debug.arch.hsr = lower_32_bits(esr);
> + run->debug.arch.hsr_high = upper_32_bits(esr);
> + run->flags |= KVM_DEBUG_ARCH_HSR_HIGH_VALID;
Who will eventually clear this flag? I'm concerned that it could be
misinterpreted by other userspace paths, as once you get a debug exit
on this vcpu, it will always be set.
Probably only a matter of clearing flags on all the other exit paths.
Also, please document the flag in the API file (only a couple of x86
flags are there so far).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-21 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 10:05 [PATCH v2 0/5] arm64: Treat ESR_ELx as a 64-bit register Alexandru Elisei
2022-04-21 10:05 ` [PATCH v2 1/5] arm64: Make ESR_ELx_xVC_IMM_MASK compatible with assembly Alexandru Elisei
2022-04-21 10:05 ` [PATCH v2 2/5] arm64: compat: Do not treat syscall number as ESR_ELx for a bad syscall Alexandru Elisei
2022-04-21 10:05 ` [PATCH v2 3/5] arm64: Treat ESR_ELx as a 64-bit register Alexandru Elisei
2022-04-21 10:05 ` [PATCH v2 4/5] KVM: arm64: Treat ESR_EL2 " Alexandru Elisei
2022-04-21 10:05 ` [PATCH v2 5/5] KVM: arm64: uapi: Add kvm_debug_exit_arch.hsr_high Alexandru Elisei
2022-04-21 12:58 ` Marc Zyngier [this message]
2022-04-21 15:22 ` Alexandru Elisei
2022-04-22 7:30 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee1qa8z7.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).