From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5279BC433F5 for ; Wed, 19 Jan 2022 18:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0a6woGG6WUegJQEz5vjOGjF5FY9woBc8+l6Tphkqmk=; b=OfPUm+//IAofxM tXa8j3bep3Qc2hjNPI8KeiTETOiQHF6yXQUvYTMNwHHhIhaYIttu3Hez7zw6nf2vmOdxRwpjeW3Px F7c+WkWW1Aw8UHq2cAmtgb3WGtMCCtbRPeBf78AW+dHJfnIjSk+R/dRLsCVYMLlxvWgtve7cST31f Bt4PV6I0D6nSweVU2OIXpKYWPDv71Im+F+NGpnDtTclYNxu1P4j1ey5KPs8ekyDx4o9F4gAC8dotU 38UnNY4mqg/A22v92BHQigFnTXfrrl11yZh21uzId94MZYRJUEKIdY27dv6o64OBCDPPApfb+tIvV GfKlbfZaQGSw9XD2nVCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAFZ4-006m8m-LD; Wed, 19 Jan 2022 18:20:10 +0000 Received: from guitar.tcltek.co.il ([84.110.109.230] helo=mx.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAFZ0-006m7a-DZ for linux-arm-kernel@lists.infradead.org; Wed, 19 Jan 2022 18:20:08 +0000 Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 49918440636; Wed, 19 Jan 2022 20:19:52 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1642616393; bh=YiIEY8EdhFZDp3IMZEZpIN5BqRDWJATtLtyWjFrte0I=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=NfteVB8o9UgTp3risSYPPfx0t2Ljb7tRlOACyxYlYuOXbP1XT0Yt1HTJVFWIn8ko6 tpsesLrXuTlmSGyMNUvS8dFWWY66SxlPj8PoOT+hFq8QCpjRl2gkcEEVV+Fl/bVEHo 7gF/EsMuv8+SPcU06rJfjx0vxx8Lqm4jSXGlJXlsm3hB0HtERYCTKApvEmC7I3jhBh 8QA2dMzKOTz6Qoco4IF+fL7bKdxvoojNfV292IC7mt0LQUk13TEQ4sKwSTGWmyZm+T V+kgBw1OLNzY1VfXhdnSqluAY5gqL7iyNAkFBQc1j3dgIi53nni8XhjfX2uvtH8bnJ v/OSnLXf4ox2w== References: <20220119002438.106079-1-sean.anderson@seco.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Sean Anderson Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Felipe Balbi , Thinh Nguyen , Balaji Prakash J , linux-kernel@vger.kernel.org, Robert Hancock , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Wed, 19 Jan 2022 20:14:06 +0200 In-reply-to: <20220119002438.106079-1-sean.anderson@seco.com> Message-ID: <87ee53fv01.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_102006_892702_049AF18F X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sean, On Tue, Jan 18 2022, Sean Anderson wrote: > This is a rework of patches 3-5 of [1]. It attempts to correctly program > REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since > we no longer need a special property duplicating this configuration, > snps,ref-clock-period-ns is deprecated. > > Please test this! Patches 3/4 in this series have the effect of > programming REFCLKPER and REFCLK_FLADJ on boards which already configure > the "ref" clock. I have build tested, but not much else. Tested here on IPQ6010 based system. USB still works. But the with "ref" clock at 24MHz, period is calculated as 0x29. Previous snps,ref-clock-period-ns value used to be 0x32. Is that expected? Thanks, baruch > > [1] https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ > > Changes in v2: > - Document clock members > - Also program GFLADJ.240MHZDECR > - Don't program GFLADJ if the version is < 2.50a > - Add snps,ref-clock-frequency-hz property for ACPI > > Sean Anderson (7): > dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns > usb: dwc3: Get clocks individually > usb: dwc3: Calculate REFCLKPER based on reference clock > usb: dwc3: Program GFLADJ > usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI > arm64: dts: zynqmp: Move USB clocks to dwc3 node > arm64: dts: ipq6018: Use reference clock to set dwc3 period > > .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- > .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- > drivers/usb/dwc3/core.c | 112 +++++++++++++++--- > drivers/usb/dwc3/core.h | 17 ++- > 6 files changed, 120 insertions(+), 27 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel