From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507DBC433EF for ; Fri, 17 Sep 2021 13:56:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20B2460240 for ; Fri, 17 Sep 2021 13:56:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 20B2460240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w6lEWqFiqF+JGN7lJ4AxtXzz0qf4bHbd+hgDR202FEM=; b=be59OYiuUedYA+ rbqxcPZgeFzvaPW0n3iNVcvlRyddAiEkPVgoRzB1IEl5rwwEyuCB62cWlDW+Hrn01BLSW58u5MeAc pqZHUrGi8TFPD2cJZH/D6Qi0waq2QXVg4It9YKWg7bAdMDlrufBwqmfW8qCtzg3/jS7yjLj50pKvu xpBfFndbkE8/aaT1GXREVd6bF06NjwhEavwFbbx2itRWLPpgNDLTw/nACxY/MIcFrefZZLL2rmVFN PdJVXaHbt//AvKDqXU449o3s6rVqspP8sgvNxUl9FYKR2lAyavdRtO6WBwTER0mPFuxIIW8WLIMGB STC+UgwBUxenncJhdkNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mREJr-00EN2B-IE; Fri, 17 Sep 2021 13:54:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mREJn-00EN1N-JO for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 13:54:20 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E310C611C3; Fri, 17 Sep 2021 13:54:18 +0000 (UTC) Received: from [198.52.44.129] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mREJl-00BNoO-0m; Fri, 17 Sep 2021 14:54:17 +0100 Date: Fri, 17 Sep 2021 14:54:11 +0100 Message-ID: <87ee9nb94s.wl-maz@kernel.org> From: Marc Zyngier To: Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Pali =?UTF-8?B?Um9ow6Fy?= , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking In-Reply-To: <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 198.52.44.129 X-SA-Exim-Rcpt-To: hayashi.kunihiko@socionext.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, pali@kernel.org, mhiramat@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_065419_701132_90D5FA94 X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Sep 2021 12:30:52 +0100, Kunihiko Hayashi wrote: > > Gentle ping, are there any comments about this series? > > Thank you, > > On 2021/08/30 11:22, Kunihiko Hayashi wrote: > > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe > > host controller driver. > > > > - Remove unnecessary bit clears to INTX mask field > > - Remove unnecessary irq_ack() function because write access to status field > > doesn't work > > - Add lock into callback functions to avoid race condition > > > > Kunihiko Hayashi (2): > > PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack > > function > > PCI: uniphier: Serialize INTx masking/unmasking > > > > drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- > > 1 file changed, 10 insertions(+), 16 deletions(-) > > Patches look OK, although I would personally squash them into a single one (INTx masking never really worked before that). FWIW: Acked-by: Marc Zyngier N, -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel