* [PATCH] arm64: entry: remove test_irqs_unmasked macro
@ 2021-03-23 18:12 Mark Rutland
2021-03-23 18:41 ` Marc Zyngier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mark Rutland @ 2021-03-23 18:12 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Mark Rutland, Catalin marinas, James Morse, Marc Zyngier,
Will Deacon
We haven't needed the test_irqs_unmasked macro since commit:
105fc3352077bba5 ("arm64: entry: move el1 irq/nmi logic to C")
... and as we convert more of the entry logic to C it is decreasingly
likely we'll need it in future, so let's remove the unused macro.
There should be no functional change as a result of this patch.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin marinas <catalin.marinas@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Will Deacon <will@kernel.org>
---
arch/arm64/kernel/entry.S | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index a31a0a713c85..a82af88e8599 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -499,20 +499,6 @@ tsk .req x28 // current thread_info
irq_stack_exit
.endm
-#ifdef CONFIG_ARM64_PSEUDO_NMI
- /*
- * Set res to 0 if irqs were unmasked in interrupted context.
- * Otherwise set res to non-0 value.
- */
- .macro test_irqs_unmasked res:req, pmr:req
-alternative_if ARM64_HAS_IRQ_PRIO_MASKING
- sub \res, \pmr, #GIC_PRIO_IRQON
-alternative_else
- mov \res, xzr
-alternative_endif
- .endm
-#endif
-
.macro gic_prio_kentry_setup, tmp:req
#ifdef CONFIG_ARM64_PSEUDO_NMI
alternative_if ARM64_HAS_IRQ_PRIO_MASKING
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: entry: remove test_irqs_unmasked macro
2021-03-23 18:12 [PATCH] arm64: entry: remove test_irqs_unmasked macro Mark Rutland
@ 2021-03-23 18:41 ` Marc Zyngier
2021-03-25 9:35 ` Will Deacon
2021-03-26 11:06 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2021-03-23 18:41 UTC (permalink / raw)
To: Mark Rutland; +Cc: linux-arm-kernel, Catalin marinas, James Morse, Will Deacon
On Tue, 23 Mar 2021 18:12:01 +0000,
Mark Rutland <mark.rutland@arm.com> wrote:
>
> We haven't needed the test_irqs_unmasked macro since commit:
>
> 105fc3352077bba5 ("arm64: entry: move el1 irq/nmi logic to C")
>
> ... and as we convert more of the entry logic to C it is decreasingly
> likely we'll need it in future, so let's remove the unused macro.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin marinas <catalin.marinas@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Will Deacon <will@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: entry: remove test_irqs_unmasked macro
2021-03-23 18:12 [PATCH] arm64: entry: remove test_irqs_unmasked macro Mark Rutland
2021-03-23 18:41 ` Marc Zyngier
@ 2021-03-25 9:35 ` Will Deacon
2021-03-26 11:06 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-03-25 9:35 UTC (permalink / raw)
To: Mark Rutland; +Cc: linux-arm-kernel, Catalin marinas, James Morse, Marc Zyngier
On Tue, Mar 23, 2021 at 06:12:01PM +0000, Mark Rutland wrote:
> We haven't needed the test_irqs_unmasked macro since commit:
>
> 105fc3352077bba5 ("arm64: entry: move el1 irq/nmi logic to C")
>
> ... and as we convert more of the entry logic to C it is decreasingly
> likely we'll need it in future, so let's remove the unused macro.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin marinas <catalin.marinas@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Will Deacon <will@kernel.org>
> ---
> arch/arm64/kernel/entry.S | 14 --------------
> 1 file changed, 14 deletions(-)
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: entry: remove test_irqs_unmasked macro
2021-03-23 18:12 [PATCH] arm64: entry: remove test_irqs_unmasked macro Mark Rutland
2021-03-23 18:41 ` Marc Zyngier
2021-03-25 9:35 ` Will Deacon
@ 2021-03-26 11:06 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-03-26 11:06 UTC (permalink / raw)
To: Mark Rutland, linux-arm-kernel; +Cc: Will Deacon, Marc Zyngier, James Morse
On Tue, 23 Mar 2021 18:12:01 +0000, Mark Rutland wrote:
> We haven't needed the test_irqs_unmasked macro since commit:
>
> 105fc3352077bba5 ("arm64: entry: move el1 irq/nmi logic to C")
>
> ... and as we convert more of the entry logic to C it is decreasingly
> likely we'll need it in future, so let's remove the unused macro.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: entry: remove test_irqs_unmasked macro
https://git.kernel.org/arm64/c/9eef29d8c31b
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-26 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-23 18:12 [PATCH] arm64: entry: remove test_irqs_unmasked macro Mark Rutland
2021-03-23 18:41 ` Marc Zyngier
2021-03-25 9:35 ` Will Deacon
2021-03-26 11:06 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).