From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC2AC433E1 for ; Fri, 17 Jul 2020 12:39:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F347220717 for ; Fri, 17 Jul 2020 12:39:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qv0tP1ho"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nzwaz+Zz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F347220717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OKN2ffFkS5YUmLnJ0pCK+us7Uwy4FAOjJdUg59wSe7g=; b=qv0tP1ho9textcvrIcwjykWeu r5gs3CfGxaPmkAtB5PRyUTptyzADCSOT0xVUjt92xqrFF4/47PXetPGvima9qzUlKYNfIYU7guUUb dMizpBiEoe2NZ/ozc9w7V5MYStFFK4j5pEVFBfUfCTpyhasWrcLONO2RxqWdCnCbr7ltzcgbOd+pE pWYBL1B6+GM4+cmS4h3M5vBSiYdvc+pqGuNNfnZif6Cpm5q0DSoG2CGVTGAXumY+U11IxmCnWE9wQ yckury/xWOftPwbSSO/aJTcJba+oZAejtnX3P2WI64C7nJVKWIG/tvW9Aq3zNKR3rW/P2AfrSV7i+ SuF2DLTIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwPcl-0005Sj-V5; Fri, 17 Jul 2020 12:37:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwPcj-0005S2-JT for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 12:37:58 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E170720717; Fri, 17 Jul 2020 12:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594989477; bh=8rxV1xvju/8foQ9apsiU1bhWwlzXKlFsLK3ubUrwX4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nzwaz+ZzCa8l2Dkyd2NU0KQYW5ni1IOTcr/Izc7flRw7ziaLO+Vtmtov2YFQqaLuo KHPmAJGeB65truNsIbP5K1OINeNHvhzJvarAiYpUGtAiLu1gG5paeXWAq/T1MUB99w AXNM4Q6Jzdew2UZA/CV5LHR3Z7JQ4YgfXw5/rEZc= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwPch-00Cclh-9K; Fri, 17 Jul 2020 13:37:55 +0100 Date: Fri, 17 Jul 2020 13:37:54 +0100 Message-ID: <87eepaxqot.wl-maz@kernel.org> From: Marc Zyngier To: Alexandre Torgue Subject: Re: [PATCH] irqchip/stm32-exti: map direct event to irq parent In-Reply-To: <69fb49b4-6a41-edf4-fea3-3f10934817ca@st.com> References: <20200706081106.25125-1-alexandre.torgue@st.com> <202007081232.bA2RH80f%lkp@intel.com> <87imevemwg.wl-maz@kernel.org> <69fb49b4-6a41-edf4-fea3-3f10934817ca@st.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandre.torgue@st.com, lkp@intel.com, tglx@linutronix.de, jason@lakedaemon.net, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, marex@denx.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_083757_772196_58881BEF X-CRM114-Status: GOOD ( 33.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, kbuild-all@lists.01.org, kernel test robot , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 10 Jul 2020 10:37:47 +0100, Alexandre Torgue wrote: > > Hi Marc, > > On 7/10/20 11:31 AM, Marc Zyngier wrote: > > Alexandre, > > > > On Wed, 08 Jul 2020 05:57:24 +0100, > > kernel test robot wrote: > >> > >> [1 ] > >> Hi Alexandre, > >> > >> I love your patch! Perhaps something to improve: > >> > >> [auto build test WARNING on stm32/stm32-next] > >> [also build test WARNING on soc/for-next v5.8-rc4 next-20200707] > >> [If your patch is applied to the wrong git tree, kindly drop us a note. > >> And when submitting patch, we suggest to use as documented in > >> https://git-scm.com/docs/git-format-patch] > >> > >> url: https://github.com/0day-ci/linux/commits/Alexandre-Torgue/irqchip-stm32-exti-map-direct-event-to-irq-parent/20200706-161327 > >> base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next > >> config: arm-randconfig-s031-20200707 (attached as .config) > >> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > >> reproduce: > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> # apt-get install sparse > >> # sparse version: v0.6.2-31-gabbfd661-dirty > >> # save the attached .config to linux build tree > >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm > >> > >> If you fix the issue, kindly add following tag as appropriate > >> Reported-by: kernel test robot > >> > >> All warnings (new ones prefixed by >>): > >> > >> In file included from include/linux/build_bug.h:5, > >> from include/linux/bits.h:23, > >> from include/linux/bitops.h:5, > >> from drivers/irqchip/irq-stm32-exti.c:8: > >> drivers/irqchip/irq-stm32-exti.c: In function 'stm32_exti_h_domain_alloc': > >> drivers/irqchip/irq-stm32-exti.c:683:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > >> 683 | if (desc->irq_parent >= 0) { > >> | ^~ > >> include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' > >> 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) > >> | ^~~~ > >>>> drivers/irqchip/irq-stm32-exti.c:683:2: note: in expansion of macro 'if' > >> 683 | if (desc->irq_parent >= 0) { > > > > Do you plan to address this? Looks like an actual bug to me. > > I'll fix it in v2, I was just waiting for other comments before > sending a v2. Do you prefer I send a v2 with this fix, and you'll do > your review on this v2 ? I'm certainly not going to review something that has such a glaring issue. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel