From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A0BC10DCE for ; Fri, 13 Mar 2020 20:13:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66B4B2074A for ; Fri, 13 Mar 2020 20:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Inwl6cq+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66B4B2074A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ak8q6Chtgpgcvcf+RN4AVWwCkUB9+zuBypdYlTyh8jo=; b=Inwl6cq+i2Fer/ nPPsVnS5steU+Urs6brmwXsq4UgVQ9rYYf5AOiCHqCw7Zd7bP/eCBcVAp3vaRdHdrzCrP+rLhHvxm gyUimB+9lWb9MZ6ZEsInCLOjj0yWH6/fYCfYjlOe7lT/wFDIor3I6/QxJ3pUH/rjgR4gQSnx1jC8o C5P3Qq4qDOxF7gC2yUHDW/DBg3EPRirv4irwXm0WP5mskd0IvKWOnBnWF+u4cNniT9czL6VS9UzFZ ySoPrx4D0v5QPBM7pXkP3D3oLUz5GqQNbO3tYvMq+rg1pgSs2z7wvCrkULPme4ZE8RN43MbBa8bsQ Wbacj4MrSmNQUj7/b84A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCqgm-000700-Dw; Fri, 13 Mar 2020 20:13:48 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCqgj-0006y3-4R for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 20:13:47 +0000 X-Originating-IP: 87.231.134.186 Received: from localhost (87-231-134-186.rev.numericable.fr [87.231.134.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5E8881BF206; Fri, 13 Mar 2020 20:13:35 +0000 (UTC) From: Gregory CLEMENT To: Russell King Subject: Re: [PATCH] arm64: dts: clearfog-gt-8k: set gigabit PHY reset deassert delay In-Reply-To: References: Date: Fri, 13 Mar 2020 21:13:34 +0100 Message-ID: <87eetwypw1.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_131345_309697_DECB978D X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Baruch Siach , Jason Cooper , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, > If the mv88e6xxx DSA driver is built as a module, it causes the > ethernet driver to re-probe when it's loaded. This in turn causes > the gigabit PHY to be momentarily reset and reprogrammed. However, > we attempt to reprogram the PHY immediately after deasserting reset, > and the PHY ignores the writes. > > This results in the PHY operating in the wrong mode, and the copper > link states down. > > Set a reset deassert delay of 10ms for the gigabit PHY to avoid this. > > Fixes: babc5544c293 ("arm64: dts: clearfog-gt-8k: 1G eth PHY reset signal") > Signed-off-by: Russell King Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > index bd881497b872..dc531d136273 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > @@ -367,6 +367,7 @@ > pinctrl-0 = <&cp0_copper_eth_phy_reset>; > reset-gpios = <&cp0_gpio2 11 GPIO_ACTIVE_LOW>; > reset-assert-us = <10000>; > + reset-deassert-us = <10000>; > }; > > switch0: switch0@4 { > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel