From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Joshua Scott <joshua.scott@alliedtelesis.co.nz>,
linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Joshua Scott <joshua.scott@alliedtelesis.co.nz>
Subject: Re: [PATCH v2] serial: prevent armada-xp-98DX SOC uart buffer loss
Date: Tue, 25 Jun 2019 10:27:39 +0200 [thread overview]
Message-ID: <87ef3ikr2c.fsf@FE-laptop> (raw)
In-Reply-To: <20190624234900.7315-1-joshua.scott@alliedtelesis.co.nz>
Hi Joshua,
> Switch to the "marvell,armada-38x-uart" driver variant to empty
> the UART buffer before writing to the UART_LCR register.
>
> Signed-off-by: Joshua Scott <joshua.scott@alliedtelesis.co.nz>
I agree with the content of this patch, so you can add my
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>.
However, could you change the title to something like: "ARM: dts:
armada-xp-98dx3236: Switch to armada-38x-uart for serial node"
Indeed for thearm device tree patch we expect that the title start by
"ARM: dts: ". Also could you add back some part of the explanation you
providee in comment with your first patch. I find it very usefull to se
waht happen and who to reproduce the bug.
Finally, as it is a fix, could you add a "Fixes: " tag as well as the
"Cc: stable@kernel.org" tag.
Thanks,
Gregory
> ---
> Changes in v2:
>
> Andrew Lunn was able to test on a Marvell 370RD reference design, and
> the character loss issue did not occur.
>
> The fix has now been changed to only affect the following SOCs:
> * 98DX323x
> * 98DX3333
> * 98DX4251
>
> Cheers,
> Joshua Scott
> ---
> arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 59753470cd34..267d0c178e55 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -336,3 +336,11 @@
> status = "disabled";
> };
>
> +&uart0 {
> + compatible = "marvell,armada-38x-uart";
> +};
> +
> +&uart1 {
> + compatible = "marvell,armada-38x-uart";
> +};
> +
> --
> 2.21.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-25 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 23:49 [PATCH v2] serial: prevent armada-xp-98DX SOC uart buffer loss Joshua Scott
2019-06-25 8:27 ` Gregory CLEMENT [this message]
2019-06-25 12:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef3ikr2c.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=joshua.scott@alliedtelesis.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).