From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6557C48BD6 for ; Tue, 25 Jun 2019 08:28:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E561205ED for ; Tue, 25 Jun 2019 08:28:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Whbj+LJm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E561205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sKWt44Uk2ncSssl2bumsUCvqPIChMCaiCVXV8H7WojE=; b=Whbj+LJmMUB0sE j/vcixJCjof+M71T+iRAFY2oWUm5x/BbL7+yWhnkT+sU/VMQnYUeT68RIoIoVIdHNjawxlpVN9na9 /3KGZu8T+9jaUE6i5uvHkVXa1hodhwypY8gtnOeJvLo1hzwo2XlPIkQ+3U+EEh2HhIGJkob68zH7a KbiFxyjB+yly2fDfwLXhK8Da13kKOP6vW4bBNCaa9ALGmg9JMZN51ZEnZDpP+Mf84+ZauiNxoRY3/ 5Cjfzl+9vKE/T3U01qBglyICvq5jUi8iSX84aB50GstSIo0SeVxzgsNx3Ue4TidEwXGHS1ZU6o6cA SMaZhThCP0MQstCqf1aQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfgoT-0003yK-9U; Tue, 25 Jun 2019 08:28:25 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfgnz-0003XZ-8W for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 08:27:57 +0000 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: gregory.clement@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D44ED100010; Tue, 25 Jun 2019 08:27:39 +0000 (UTC) From: Gregory CLEMENT To: Joshua Scott , linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth Subject: Re: [PATCH v2] serial: prevent armada-xp-98DX SOC uart buffer loss In-Reply-To: <20190624234900.7315-1-joshua.scott@alliedtelesis.co.nz> References: <20190624234900.7315-1-joshua.scott@alliedtelesis.co.nz> Date: Tue, 25 Jun 2019 10:27:39 +0200 Message-ID: <87ef3ikr2c.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_012755_494299_723F5C0D X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joshua Scott Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joshua, > Switch to the "marvell,armada-38x-uart" driver variant to empty > the UART buffer before writing to the UART_LCR register. > > Signed-off-by: Joshua Scott I agree with the content of this patch, so you can add my Acked-by: Gregory CLEMENT . However, could you change the title to something like: "ARM: dts: armada-xp-98dx3236: Switch to armada-38x-uart for serial node" Indeed for thearm device tree patch we expect that the title start by "ARM: dts: ". Also could you add back some part of the explanation you providee in comment with your first patch. I find it very usefull to se waht happen and who to reproduce the bug. Finally, as it is a fix, could you add a "Fixes: " tag as well as the "Cc: stable@kernel.org" tag. Thanks, Gregory > --- > Changes in v2: > > Andrew Lunn was able to test on a Marvell 370RD reference design, and > the character loss issue did not occur. > > The fix has now been changed to only affect the following SOCs: > * 98DX323x > * 98DX3333 > * 98DX4251 > > Cheers, > Joshua Scott > --- > arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi > index 59753470cd34..267d0c178e55 100644 > --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi > +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi > @@ -336,3 +336,11 @@ > status = "disabled"; > }; > > +&uart0 { > + compatible = "marvell,armada-38x-uart"; > +}; > + > +&uart1 { > + compatible = "marvell,armada-38x-uart"; > +}; > + > -- > 2.21.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel