From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885C3C43381 for ; Thu, 7 Mar 2019 19:24:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47933205C9 for ; Thu, 7 Mar 2019 19:24:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A5UijcwI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47933205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uQGto70xsAvTodctbSBuItre90dH0wqQMhyUWSJD5/I=; b=A5UijcwI5e2z+R 2BFYNnV8m3nQVZ7+C0TM8isuggKbZPazuNvoLNaQfWcTzuKR8bKJao6fRfxwEIfZcHr2JUXv1V7f3 9iQtnlkfOAwZFDv7wjwD7zUZYtP2eAhq8ElxmOfNhqGr0Dl3kbyFkPEe1pRXoaI2RbMbXacMS4U1C bBf4FVwNHnD12/7YtR1tDx1rK9hulTep06GwUVIA7wPv+4W0beUYQw9Z2BUTx1QnKLP4Jkb4OXUt/ ZvmCmkEbHx47kanfwL+yGBXsRkpdZ+oj/VI17ZGhOvobat3fD7lUIHHcRbneNnEUNZo7AOQUs8kA4 vG5FALyqZH0gj2HARJww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1ydC-0001W7-Pf; Thu, 07 Mar 2019 19:24:38 +0000 Received: from smtp12.smtpout.orange.fr ([80.12.242.134] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1yd8-0001Vc-IQ for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 19:24:36 +0000 Received: from belgarion ([90.76.35.80]) by mwinf5d23 with ME id l7QQ1z0081jkVcS037QQNZ; Thu, 07 Mar 2019 20:24:29 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 07 Mar 2019 20:24:29 +0100 X-ME-IP: 90.76.35.80 From: Robert Jarzmik To: Andy Shevchenko Subject: Re: [PATCH v1 2/3] spi: pxa2xx: Introduce dma-burst-sz property support References: <20190226092441.49198-1-andriy.shevchenko@linux.intel.com> <20190226092441.49198-2-andriy.shevchenko@linux.intel.com> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 07 Mar 2019 20:24:24 +0100 In-Reply-To: <20190226092441.49198-2-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Tue, 26 Feb 2019 12:24:40 +0300") Message-ID: <87ef7i5vyv.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_112434_888561_D935DBF6 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Mark Brown , Haojian Zhuang , linux-spi@vger.kernel.org, Rob Herring , Jarkko Nikula , linux-arm-kernel@lists.infradead.org, Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andy Shevchenko writes: > @@ -1512,6 +1513,7 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > const struct acpi_device_id *adev_id = NULL; > const struct pci_device_id *pcidev_id = NULL; > const struct of_device_id *of_id = NULL; > + struct device *dev = &pdev->dev; > enum pxa_ssp_type type; > > adev = ACPI_COMPANION(&pdev->dev); > @@ -1566,9 +1568,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > ssp->pdev = pdev; > ssp->port_id = pxa2xx_spi_get_port_id(adev); > > - pdata->is_slave = of_property_read_bool(pdev->dev.of_node, "spi-slave"); > + pdata->is_slave = device_property_read_bool(dev, "spi-slave"); Isn't this an unrelated change to the introduction of dma-burst-sz ? Other than this : Reviewed-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel